Add skeleton for select-to-speak component extension.

Add skeleton for select-to-speak component extension.

Shares some of the build rules from ChromeVox, but with no extension tests or
Closure compilation rules yet. We can add those later as needed.

If you run Chrome with the --enable-experimental-accessibility-features
flag, then toggling the Select-to-speak checkbox in the accessibility
preferences loads or unloads this component extension, as verified by the
presence of the (empty) background script in chrome://inspect

BUG=593887
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=rdevlin.cronin

Committed: https://crrev.com/5288b26171229540116cc44b3505a28f051b5ffc
Cr-Commit-Position: refs/heads/master@{#419318}

[dmazzoni, 2016-08-04 21:21:33]

Description was changed from

==========
Add skeleton for select-to-speak component extension.

Shares some of the build rules from ChromeVox, but with no extension tests or
Closure compilation rules yet. We can add those later as needed.

If you run Chrome with the --enable-experimental-accessibility-features
flag, then toggling the Select-to-speak checkbox in the accessibility
preferences loads or unloads this component extension, as verified by the
presence of the (empty) background script in chrome://inspect

BUG=593887
==========

to

==========
Add skeleton for select-to-speak component extension.

Shares some of the build rules from ChromeVox, but with no extension tests or
Closure compilation rules yet. We can add those later as needed.

If you run Chrome with the --enable-experimental-accessibility-features
flag, then toggling the Select-to-speak checkbox in the accessibility
preferences loads or unloads this component extension, as verified by the
presence of the (empty) background script in chrome://inspect

BUG=593887
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dmazzoni, 2016-08-04 21:47:31]

dmazzoni@chromium.org changed reviewers:
+ dtseng@google.com

[dmazzoni, 2016-09-14 21:41:11]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org
- dtseng@google.com

[dmazzoni, 2016-09-14 21:41:12]

The dependencies have all landed, this is rebased and ready for review

[David Tseng, 2016-09-16 21:16:03]

lgtm

bb

https://codereview.chromium.org/2216433004/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right):

https://codereview.chromium.org/2216433004/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/accessibility/accessibility_manager.cc:847:
select_to_speak_loader_->Load(profile_, "", base::Closure());
"" /* param_name */

https://codereview.chromium.org/2216433004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/select_to_speak/BUILD.gn (right):

https://codereview.chromium.org/2216433004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/select_to_speak/BUILD.gn:36:
template("manifest") {
Optional: would be great to share this in another file (e.g.
generate_manifest.gni).

https://codereview.chromium.org/2216433004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/select_to_speak/manifest.json.jinja2
(right):

https://codereview.chromium.org/2216433004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/select_to_speak/manifest.json.jinja2:6:
"name": "X__MSG_SELECT_TO_SPEAK_NAME__",
Is this a TODO (hence the X prefix)?

https://codereview.chromium.org/2216433004/diff/40001/chrome/common/extension...
File chrome/common/extensions/extension_constants.h (right):

https://codereview.chromium.org/2216433004/diff/40001/chrome/common/extension...
chrome/common/extensions/extension_constants.h:203: // Path to preinstalled
ChromeVox screen reader extension (relative to
Update

[dmazzoni, 2016-09-16 22:05:43]

Description was changed from

==========
Add skeleton for select-to-speak component extension.

Shares some of the build rules from ChromeVox, but with no extension tests or
Closure compilation rules yet. We can add those later as needed.

If you run Chrome with the --enable-experimental-accessibility-features
flag, then toggling the Select-to-speak checkbox in the accessibility
preferences loads or unloads this component extension, as verified by the
presence of the (empty) background script in chrome://inspect

BUG=593887
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add skeleton for select-to-speak component extension.

Shares some of the build rules from ChromeVox, but with no extension tests or
Closure compilation rules yet. We can add those later as needed.

If you run Chrome with the --enable-experimental-accessibility-features
flag, then toggling the Select-to-speak checkbox in the accessibility
preferences loads or unloads this component extension, as verified by the
presence of the (empty) background script in chrome://inspect

BUG=593887
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=rdevlin.cronin
==========

[dmazzoni, 2016-09-16 22:05:43]

dmazzoni@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[dmazzoni, 2016-09-16 22:06:19]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-09-16 22:06:20]

+TBR=rdevlin.cronin for trivial additions to
chrome/common/extensions/extension_constants.*

https://codereview.chromium.org/2216433004/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right):

https://codereview.chromium.org/2216433004/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/accessibility/accessibility_manager.cc:847:
select_to_speak_loader_->Load(profile_, "", base::Closure());
On 2016/09/16 at 21:16:02, David Tseng wrote:
> "" /* param_name */

Done

https://codereview.chromium.org/2216433004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/select_to_speak/BUILD.gn (right):

https://codereview.chromium.org/2216433004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/select_to_speak/BUILD.gn:36:
template("manifest") {
On 2016/09/16 at 21:16:02, David Tseng wrote:
> Optional: would be great to share this in another file (e.g.
generate_manifest.gni).

Added a TODO

https://codereview.chromium.org/2216433004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/select_to_speak/manifest.json.jinja2
(right):

https://codereview.chromium.org/2216433004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/select_to_speak/manifest.json.jinja2:6:
"name": "X__MSG_SELECT_TO_SPEAK_NAME__",
On 2016/09/16 at 21:16:02, David Tseng wrote:
> Is this a TODO (hence the X prefix)?

Made it a more explicit TODO

https://codereview.chromium.org/2216433004/diff/40001/chrome/common/extension...
File chrome/common/extensions/extension_constants.h (right):

https://codereview.chromium.org/2216433004/diff/40001/chrome/common/extension...
chrome/common/extensions/extension_constants.h:203: // Path to preinstalled
ChromeVox screen reader extension (relative to
On 2016/09/16 at 21:16:03, David Tseng wrote:
> Update

Fixed

[dmazzoni, 2016-09-16 22:06:20]

The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org
Link to the patchset: https://codereview.chromium.org/2216433004/#ps80001
(title: "Fix warning")

[commit-bot: I haz the power, 2016-09-16 22:07:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-09-16 22:13:45]

lgtm

https://codereview.chromium.org/2216433004/diff/80001/chrome/common/extension...
File chrome/common/extensions/extension_constants.cc (right):

https://codereview.chromium.org/2216433004/diff/80001/chrome/common/extension...
chrome/common/extensions/extension_constants.cc:65: const char
kSelectToSpeakExtensionPath[] = "chromeos/select_to_speak";
nit: should this be a FILE_PATH_LITERAL?

[commit-bot: I haz the power, 2016-09-16 23:05:57]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-16 23:08:50]

Description was changed from

==========
Add skeleton for select-to-speak component extension.

Shares some of the build rules from ChromeVox, but with no extension tests or
Closure compilation rules yet. We can add those later as needed.

If you run Chrome with the --enable-experimental-accessibility-features
flag, then toggling the Select-to-speak checkbox in the accessibility
preferences loads or unloads this component extension, as verified by the
presence of the (empty) background script in chrome://inspect

BUG=593887
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=rdevlin.cronin
==========

to

==========
Add skeleton for select-to-speak component extension.

Shares some of the build rules from ChromeVox, but with no extension tests or
Closure compilation rules yet. We can add those later as needed.

If you run Chrome with the --enable-experimental-accessibility-features
flag, then toggling the Select-to-speak checkbox in the accessibility
preferences loads or unloads this component extension, as verified by the
presence of the (empty) background script in chrome://inspect

BUG=593887
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=rdevlin.cronin

Committed: https://crrev.com/5288b26171229540116cc44b3505a28f051b5ffc
Cr-Commit-Position: refs/heads/master@{#419318}
==========

[commit-bot: I haz the power, 2016-09-16 23:08:51]

Patchset 5 (id:??) landed as
https://crrev.com/5288b26171229540116cc44b3505a28f051b5ffc
Cr-Commit-Position: refs/heads/master@{#419318}