Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issue 2216433003: [wasm] Turn off wasm jit tests. (Closed)

Created:
4 years, 4 months ago by ahaas
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Turn off wasm jit tests. There seems to be a fundamental problem with calling runtime functions from wasm if the runtime function can cause a GC. NOTRY=true R=machenbach@chromium.org, titzer@chromium.org Committed: https://crrev.com/d61c9873ee9ef7852cb5dbbfef3e3a183eee9935 Cr-Commit-Position: refs/heads/master@{#38340}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ahaas
4 years, 4 months ago (2016-08-04 12:03:59 UTC) #1
Michael Achenbach
lgtm
4 years, 4 months ago (2016-08-04 12:30:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216433003/1
4 years, 4 months ago (2016-08-04 12:36:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 12:39:02 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 12:41:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d61c9873ee9ef7852cb5dbbfef3e3a183eee9935
Cr-Commit-Position: refs/heads/master@{#38340}

Powered by Google App Engine
This is Rietveld 408576698