OobeLocalizationTest.LocalizationTest : implement test timeouts.

OobeLocalizationTest.LocalizationTest : implement test timeouts.

This CL removes race in LocalizationTest and also adds timeouts to debug
test flakiness.

BUG=633246
Committed: https://crrev.com/7d82f6f3361bd36fbd4e36ac0140506d4be2bf50
Cr-Commit-Position: refs/heads/master@{#410179}

[Alexander Alekseev, 2016-08-04 05:08:03]

alemate@chromium.org changed reviewers:
+ stevenjb@chromium.org

[Alexander Alekseev, 2016-08-04 05:08:04]

Please review.

[Alexander Alekseev, 2016-08-04 05:08:11]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 05:08:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 05:51:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 05:51:51]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2016-08-04 17:04:41]

https://codereview.chromium.org/2216433002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/oobe_localization_browsertest.cc (right):

https://codereview.chromium.org/2216433002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/oobe_localization_browsertest.cc:76: LOG(FATAL) <<
"Timeout waiting for: " << message_;
This will cause the entire test suite to crash, which is not what we want.
Instead we should log an error and call loop_.Quit(), at which point the test
itself should fail.

https://codereview.chromium.org/2216433002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/oobe_localization_browsertest.cc:103: return;
Hmm, good catch, this might have been the problem.

[Alexander Alekseev, 2016-08-05 03:42:00]

https://codereview.chromium.org/2216433002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/oobe_localization_browsertest.cc (right):

https://codereview.chromium.org/2216433002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/oobe_localization_browsertest.cc:76: LOG(FATAL) <<
"Timeout waiting for: " << message_;
On 2016/08/04 17:04:41, stevenjb wrote:
> This will cause the entire test suite to crash, which is not what we want.
> Instead we should log an error and call loop_.Quit(), at which point the test
> itself should fail.

Done.

[stevenjb, 2016-08-05 16:26:45]

LGTM, thanks!

[Alexander Alekseev, 2016-08-05 21:26:19]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2016-08-05 21:26:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 22:03:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-05 22:04:05]

Description was changed from

==========
OobeLocalizationTest.LocalizationTest : implement test timeouts.

This CL removes race in LocalizationTest and also adds timeouts to debug
test flakiness.

BUG=633246
==========

to

==========
OobeLocalizationTest.LocalizationTest : implement test timeouts.

This CL removes race in LocalizationTest and also adds timeouts to debug
test flakiness.

BUG=633246

Committed: https://crrev.com/7d82f6f3361bd36fbd4e36ac0140506d4be2bf50
Cr-Commit-Position: refs/heads/master@{#410179}
==========

[commit-bot: I haz the power, 2016-08-05 22:04:06]

Patchset 2 (id:??) landed as
https://crrev.com/7d82f6f3361bd36fbd4e36ac0140506d4be2bf50
Cr-Commit-Position: refs/heads/master@{#410179}