Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2216433002: OobeLocalizationTest.LocalizationTest : implement test timeouts. (Closed)

Created:
4 years, 4 months ago by Alexander Alekseev
Modified:
4 years, 4 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

OobeLocalizationTest.LocalizationTest : implement test timeouts. This CL removes race in LocalizationTest and also adds timeouts to debug test flakiness. BUG=633246 Committed: https://crrev.com/7d82f6f3361bd36fbd4e36ac0140506d4be2bf50 Cr-Commit-Position: refs/heads/master@{#410179}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix failure model. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -16 lines) Patch
M chrome/browser/chromeos/login/oobe_localization_browsertest.cc View 1 5 chunks +74 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Alexander Alekseev
Please review.
4 years, 4 months ago (2016-08-04 05:08:04 UTC) #2
stevenjb
https://codereview.chromium.org/2216433002/diff/1/chrome/browser/chromeos/login/oobe_localization_browsertest.cc File chrome/browser/chromeos/login/oobe_localization_browsertest.cc (right): https://codereview.chromium.org/2216433002/diff/1/chrome/browser/chromeos/login/oobe_localization_browsertest.cc#newcode76 chrome/browser/chromeos/login/oobe_localization_browsertest.cc:76: LOG(FATAL) << "Timeout waiting for: " << message_; This ...
4 years, 4 months ago (2016-08-04 17:04:41 UTC) #7
Alexander Alekseev
https://codereview.chromium.org/2216433002/diff/1/chrome/browser/chromeos/login/oobe_localization_browsertest.cc File chrome/browser/chromeos/login/oobe_localization_browsertest.cc (right): https://codereview.chromium.org/2216433002/diff/1/chrome/browser/chromeos/login/oobe_localization_browsertest.cc#newcode76 chrome/browser/chromeos/login/oobe_localization_browsertest.cc:76: LOG(FATAL) << "Timeout waiting for: " << message_; On ...
4 years, 4 months ago (2016-08-05 03:42:00 UTC) #8
stevenjb
LGTM, thanks!
4 years, 4 months ago (2016-08-05 16:26:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216433002/20001
4 years, 4 months ago (2016-08-05 21:26:58 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-05 22:03:06 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 22:04:06 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7d82f6f3361bd36fbd4e36ac0140506d4be2bf50
Cr-Commit-Position: refs/heads/master@{#410179}

Powered by Google App Engine
This is Rietveld 408576698