Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1722)

Issue 221643002: Only support AddFeatures invalidation set mode for :host or :any in a rightmost selector (Closed)

Created:
6 years, 8 months ago by chrishtr
Modified:
6 years, 8 months ago
Reviewers:
esprehn, rune
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

Only support AddFeatures invalidation set mode for :host or :any in selector components to the right of the rightmost descendant relation. This fixes a bug that caused this to be the case accidentally in cases such as: :host(.foo) #bar when #bar is not (yet) supported for the style invalidation tree walk. BUG=358704 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170637

Patch Set 1 #

Patch Set 2 : Fix method name. #

Patch Set 3 : Update method name. #

Patch Set 4 : Fix compilation. #

Total comments: 2

Patch Set 5 : Changed method name. #

Patch Set 6 : Fix cojmpilation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
A LayoutTests/fast/css/invalidation/shadow-host-toggle.html View 1 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/invalidation/shadow-host-toggle-expected.txt View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/css/RuleFeature.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
chrishtr
6 years, 8 months ago (2014-04-02 00:01:13 UTC) #1
esprehn
lgtm https://codereview.chromium.org/221643002/diff/60001/Source/core/css/RuleFeature.h File Source/core/css/RuleFeature.h (right): https://codereview.chromium.org/221643002/diff/60001/Source/core/css/RuleFeature.h#newcode132 Source/core/css/RuleFeature.h:132: static InvalidationSetMode getInvalidationSetMode(const CSSSelector&); We don't usually use ...
6 years, 8 months ago (2014-04-02 00:20:58 UTC) #2
chrishtr
https://codereview.chromium.org/221643002/diff/60001/Source/core/css/RuleFeature.h File Source/core/css/RuleFeature.h (right): https://codereview.chromium.org/221643002/diff/60001/Source/core/css/RuleFeature.h#newcode132 Source/core/css/RuleFeature.h:132: static InvalidationSetMode getInvalidationSetMode(const CSSSelector&); On 2014/04/02 00:20:58, esprehn wrote: ...
6 years, 8 months ago (2014-04-02 04:19:50 UTC) #3
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 8 months ago (2014-04-02 04:19:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/221643002/80001
6 years, 8 months ago (2014-04-02 04:20:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 04:32:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 8 months ago (2014-04-02 04:32:58 UTC) #7
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 8 months ago (2014-04-02 04:47:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/221643002/100001
6 years, 8 months ago (2014-04-02 04:47:37 UTC) #9
commit-bot: I haz the power
Change committed as 170637
6 years, 8 months ago (2014-04-02 05:53:33 UTC) #10
rune
6 years, 8 months ago (2014-04-02 08:13:51 UTC) #11
Message was sent while issue was closed.
lgtm. thanks for fixing!

Powered by Google App Engine
This is Rietveld 408576698