Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2216383002: TurboFan: Introduce TaggedSigned and TaggedPointer representations. (Closed)

Created:
4 years, 4 months ago by mvstanton
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

TurboFan: Introduce TaggedSigned and TaggedPointer representations. These new representations aren't used yet. BUG= Committed: https://crrev.com/d941b52d7328f6d223a1dc1ffb134221500dbb00 Cr-Commit-Position: refs/heads/master@{#38657}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Ports. #

Patch Set 3 : REBASE. #

Patch Set 4 : Mips compile fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -10 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 2 4 chunks +8 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 2 4 chunks +8 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 2 4 chunks +18 lines, -10 lines 0 comments Download
M src/compiler/instruction.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/instruction.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M src/compiler/load-elimination.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 2 3 5 chunks +10 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 2 3 6 chunks +12 lines, -0 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/representation-change.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 4 chunks +8 lines, -0 lines 0 comments Download
M src/machine-type.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/machine-type.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
mvstanton
Hi Benedikt, Here are the new enums, have a look at my "defaults." Ports to ...
4 years, 4 months ago (2016-08-05 13:54:00 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/2216383002/diff/1/src/compiler/load-elimination.cc File src/compiler/load-elimination.cc (right): https://codereview.chromium.org/2216383002/diff/1/src/compiler/load-elimination.cc#newcode648 src/compiler/load-elimination.cc:648: case MachineRepresentation::kTaggedPointer: These should be treated exactly like Tagged ...
4 years, 4 months ago (2016-08-05 18:49:01 UTC) #6
mvstanton
Hi Jaro, Since Benedikt is out, could you have a final look? Thanks! --Mike https://codereview.chromium.org/2216383002/diff/1/src/compiler/load-elimination.cc ...
4 years, 4 months ago (2016-08-16 10:50:40 UTC) #12
Jarin
lgtm
4 years, 4 months ago (2016-08-16 11:07:23 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216383002/60001
4 years, 4 months ago (2016-08-16 12:10:57 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-16 12:41:25 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 12:41:57 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d941b52d7328f6d223a1dc1ffb134221500dbb00
Cr-Commit-Position: refs/heads/master@{#38657}

Powered by Google App Engine
This is Rietveld 408576698