Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2216373002:
[test] Split TurboFan cctest expectations for variants. (Closed)
|
Created:
4 years, 4 months ago by Michael Starzinger Modified:
4 years, 4 months ago Reviewers:
Michael Achenbach CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[test] Split TurboFan cctest expectations for variants.
R=machenbach@chromium.org
Committed: https://crrev.com/476f80a98c25b0cf950a9234ad8186b8d9701215
Cr-Commit-Position: refs/heads/master@{#38427}
Patch Set 1 #Patch Set 2 : Fix comments. #Patch Set 3 : Fix for ignition_turbofan variant. #Patch Set 4 : Fix for ignition variant. #Messages
Total messages: 22 (17 generated)
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm - thanks a lot for cleaning those up!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mstarzinger@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from machenbach@chromium.org Link to the patchset: https://codereview.chromium.org/2216373002/#ps60001 (title: "Fix for ignition variant.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [test] Split TurboFan cctest expectations for variants. R=machenbach@chromium.org ========== to ========== [test] Split TurboFan cctest expectations for variants. R=machenbach@chromium.org Committed: https://crrev.com/476f80a98c25b0cf950a9234ad8186b8d9701215 Cr-Commit-Position: refs/heads/master@{#38427} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/476f80a98c25b0cf950a9234ad8186b8d9701215 Cr-Commit-Position: refs/heads/master@{#38427} |
