Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2216313002: Move GnomeKeyringLoader to components/os_crypt (Closed)

Created:
4 years, 4 months ago by cfroussios
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, vasilii
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move GnomeKeyringLoader to components/os_crypt BUG=602624 Committed: https://crrev.com/0bf3d10c186e7fb57f4f705f0bef383d26ccf28b Cr-Commit-Position: refs/heads/master@{#410087}

Patch Set 1 #

Patch Set 2 : Removed include #

Patch Set 3 : moved the configs #

Patch Set 4 : don't force static linking on every test that uses support #

Total comments: 2

Patch Set 5 : removed guard #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -160 lines) Patch
M chrome/browser/BUILD.gn View 1 2 3 chunks +1 line, -23 lines 0 comments Download
M chrome/browser/password_manager/native_backend_gnome_x.h View 2 chunks +1 line, -56 lines 0 comments Download
M chrome/browser/password_manager/native_backend_gnome_x.cc View 1 2 chunks +0 lines, -78 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M components/os_crypt/BUILD.gn View 1 2 3 4 2 chunks +29 lines, -1 line 0 comments Download
A components/os_crypt/keyring_util_linux.h View 1 chunk +66 lines, -0 lines 0 comments Download
A components/os_crypt/keyring_util_linux.cc View 1 chunk +82 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (25 generated)
cfroussios
Hi! Can you review changes in password_manager/ and related builds? Thanks!
4 years, 4 months ago (2016-08-05 14:36:34 UTC) #14
vasilii
lgtm
4 years, 4 months ago (2016-08-05 15:32:50 UTC) #17
cfroussios
thestig@chromium.org: Please review changes in chrome/browser/BUILD.gn components/os_crypt/* Thanks!
4 years, 4 months ago (2016-08-05 15:37:32 UTC) #19
Lei Zhang
lgtm https://codereview.chromium.org/2216313002/diff/60001/components/os_crypt/BUILD.gn File components/os_crypt/BUILD.gn (right): https://codereview.chromium.org/2216313002/diff/60001/components/os_crypt/BUILD.gn#newcode7 components/os_crypt/BUILD.gn:7: if (is_desktop_linux) { I don't see anyone else ...
4 years, 4 months ago (2016-08-05 15:46:38 UTC) #22
cfroussios
https://codereview.chromium.org/2216313002/diff/60001/components/os_crypt/BUILD.gn File components/os_crypt/BUILD.gn (right): https://codereview.chromium.org/2216313002/diff/60001/components/os_crypt/BUILD.gn#newcode7 components/os_crypt/BUILD.gn:7: if (is_desktop_linux) { On 2016/08/05 15:46:38, Lei Zhang wrote: ...
4 years, 4 months ago (2016-08-05 16:15:24 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216313002/80001
4 years, 4 months ago (2016-08-05 17:12:24 UTC) #30
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-05 17:16:13 UTC) #31
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 17:19:15 UTC) #33
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0bf3d10c186e7fb57f4f705f0bef383d26ccf28b
Cr-Commit-Position: refs/heads/master@{#410087}

Powered by Google App Engine
This is Rietveld 408576698