Issue 221623004: [AudioPleyer] Fix repeat even when there is a single file in the list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 221623004: [AudioPleyer] Fix repeat even when there is a single file in the list. (Closed)

Created:
6 years, 8 months ago by yoshiki

Modified:
6 years, 8 months ago

Reviewers:

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[AudioPleyer] Fix repeat even when there is a single file in the list. The repeat feature did not work if there was only a single file in the list. This patch fixes the issue. BUG=chrome-os-partner:27258 TEST=audio_player tests pass TBR=hirono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261399

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	chrome/browser/resources/file_manager/audio_player/elements/audio_player.js	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/221623004/20001

6 years, 8 months ago (2014-04-02 09:35:03 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 8 months ago (2014-04-02 16:42:25 UTC) #5

commit-bot: I haz the power

Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=60376

6 years, 8 months ago (2014-04-02 16:42:26 UTC) #6

yoshiki

6 years, 8 months ago (2014-04-03 15:03:56 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 manually as r261399 (presubmit successful).

Expand Messages | Collapse Messages