roll clang 202555:204777

roll clang 202555:204777

BUG=357890
TBR=hans@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261042

[Nico, 2014-04-02 01:25:18]

"what's better than one clang roll per day?"

[Nico, 2014-04-02 03:37:39]

Committed patchset #4 manually as r261042 (presubmit successful).

[hans, 2014-04-02 14:47:16]

lgtm \o/

Hmm, I needed to set LD_LIBRARY_PATH when building on Linux with a custom gcc
toolchain, otherwise e.g. TableGen wouldn't find the right libstd++.so, but I
guess you didn't need that?

[Nico, 2014-04-02 16:38:09]

On Wed, Apr 2, 2014 at 7:47 AM, <hans@chromium.org> wrote:

> lgtm \o/
>
> Hmm, I needed to set LD_LIBRARY_PATH when building on Linux with a custom
> gcc
> toolchain, otherwise e.g. TableGen wouldn't find the right libstd++.so,
> but I
> guess you didn't need that?
>

No. My binaries in third-party/llvm-boostrap depend on "libstdc++.so.6 =>
/usr/lib/x86_64-linux-gnu/libstdc++.so.6" according to ldd – which seems
wrong. I used the command you told me to build the package:

CC=/usr/local/google/home/thakis/gcc482prefix/bin/gcc
CXX=/usr/local/google/home/thakis/gcc482prefix/bin/g++
tools/clang/scripts/package.sh --gcc-toolchain
/usr/local/google/home/thakis/gcc482prefix

(But the binaries in third-party/llvm-boostrap-install and
third-party/llvm-build depend on the right libstdc++, so as long as the
bootstrap worked and passed all tests, this isn't a critical bug. Still
something we should figure out. ldd on
third-party/llvm-build/Release+Asserts/bin/clang yields "libstdc++.so.6 =>
/usr/local/google/home/thakis/src/chrome/src/third_party/llvm-build/Release+Asserts/bin/../lib/libstdc++.so.6",
so the packaged clang is correct.)


>
> https://codereview.chromium.org/221623003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[hans, 2014-04-03 07:27:30]

On Wed, Apr 2, 2014 at 6:38 PM, Nico Weber <thakis@chromium.org> wrote:
> On Wed, Apr 2, 2014 at 7:47 AM, <hans@chromium.org> wrote:
>>
>> lgtm \o/
>>
>> Hmm, I needed to set LD_LIBRARY_PATH when building on Linux with a custom
>> gcc
>> toolchain, otherwise e.g. TableGen wouldn't find the right libstd++.so,
>> but I
>> guess you didn't need that?
>
>
> No. My binaries in third-party/llvm-boostrap depend on "libstdc++.so.6 =>
> /usr/lib/x86_64-linux-gnu/libstdc++.so.6" according to ldd – which seems
> wrong. I used the command you told me to build the package:
>
> CC=/usr/local/google/home/thakis/gcc482prefix/bin/gcc
> CXX=/usr/local/google/home/thakis/gcc482prefix/bin/g++
> tools/clang/scripts/package.sh --gcc-toolchain
> /usr/local/google/home/thakis/gcc482prefix

Ah, I tried building without setting CC and CXX manually this time
(since as you pointed out last time, we set them in the script
anyway), and that's probably why I needed LD_LIBRARY_PATH.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.