Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2216193002: Update pdfium/annots/annotation_square_expected.pdf.0.png with actual square annotation. (Closed)

Created:
4 years, 4 months ago by jaepark
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com, dsinclair
Base URL:
https://pdfium.googlesource.com/pdfium_tests@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update pdfium/annots/annotation_square_expected.pdf.0.png with actual square annotation. Also, add test cases for square annotation with fill, opacity, dash border, and negative border width. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium_tests/+/9a1350994c9722341d0614180ceedd7cc2e37b43

Patch Set 1 #

Patch Set 2 : Update pdfium/annots/annotation_square_expected.pdf.0.png with actual square annotation. #

Patch Set 3 : Update pdfium/annots/annotation_square_expected.pdf.0.png with actual square annotation. #

Messages

Total messages: 8 (4 generated)
jaepark
It will also be helpful to add square with dash line, and filled square with ...
4 years, 4 months ago (2016-08-05 00:55:52 UTC) #2
jaepark
Updated test cases with dash lines.
4 years, 4 months ago (2016-08-05 19:02:45 UTC) #4
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-05 22:02:27 UTC) #5
jaepark
4 years, 4 months ago (2016-08-05 22:38:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
9a1350994c9722341d0614180ceedd7cc2e37b43 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698