third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h - Issue 2216133003: [css-flexbox] Simplify the "child intrinsic height" logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

Issue 2216133003: [css-flexbox] Simplify the "child intrinsic height" logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more simplification Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

index d736ddfb2a445d682de38cc26a36f25f48bed6a8..8f27a2533dbf72cfa5341ae96069d98db7f72975 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

+++ b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

@@ -117,8 +117,8 @@ private:

Length flexBasisForChild(const LayoutBox& child) const;

LayoutUnit crossAxisExtentForChild(const LayoutBox& child) const;

LayoutUnit crossAxisIntrinsicExtentForChild(const LayoutBox& child) const;

- LayoutUnit childIntrinsicHeight(const LayoutBox& child) const;

- LayoutUnit childIntrinsicWidth(const LayoutBox& child) const;

+ LayoutUnit childIntrinsicLogicalHeight(const LayoutBox& child) const;

+ LayoutUnit childIntrinsicLogicalWidth(const LayoutBox& child) const;

LayoutUnit mainAxisExtentForChild(const LayoutBox& child) const;

LayoutUnit mainAxisContentExtentForChild(const LayoutBox& child) const;

LayoutUnit crossAxisExtent() const;

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp » ('j') | no next file with comments »