Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2216133003: [css-flexbox] Simplify the "child intrinsic height" logic (Closed)

Created:
4 years, 4 months ago by cbiesinger
Modified:
4 years, 4 months ago
Reviewers:
dgrogan, eae, cbiesinger1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] Simplify the "child intrinsic height" logic The logic in childIntrinsicHeight/childIntrinsicWidth was very hard to understand. This patch makes them work on the logical width/height instead, which is much simpler. This also removes a TODO mentioning indefinite percentages, because the spec is clear that only actual auto values should be stretched. R=eae@chromium.org,dgrogan@chromium.org Committed: https://crrev.com/73e356aec7507c9e27dcbd9728511e9775d03a44 Cr-Commit-Position: refs/heads/master@{#410348}

Patch Set 1 #

Patch Set 2 : fix compile error #

Patch Set 3 : more simplification #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -20 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 2 3 chunks +17 lines, -18 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
cbiesinger
4 years, 4 months ago (2016-08-05 20:38:31 UTC) #1
eae
Nice, LGTM
4 years, 4 months ago (2016-08-08 13:01:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216133003/40001
4 years, 4 months ago (2016-08-08 13:07:49 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-08 14:20:11 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 14:21:28 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/73e356aec7507c9e27dcbd9728511e9775d03a44
Cr-Commit-Position: refs/heads/master@{#410348}

Powered by Google App Engine
This is Rietveld 408576698