Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 221613005: Add enable-embedded-shared-worker in chrome://flags/ (Closed)

Created:
6 years, 8 months ago by horo
Modified:
6 years, 8 months ago
Reviewers:
kinuko
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add enable-embedded-shared-worker in chrome://flags/ BUG=327256 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261387

Patch Set 1 : #

Patch Set 2 : incorporated kinuko's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
horo
kinuko@ Could you please review?
6 years, 8 months ago (2014-04-02 08:09:48 UTC) #1
kinuko
lgtm 'Embedded Shared Worker' -> 'In-renderer Shared Worker' might be slightly more understandable for people ...
6 years, 8 months ago (2014-04-02 17:14:22 UTC) #2
horo
On 2014/04/02 17:14:22, kinuko wrote: > lgtm > > 'Embedded Shared Worker' -> 'In-renderer Shared ...
6 years, 8 months ago (2014-04-03 03:12:06 UTC) #3
horo
The CQ bit was checked by horo@chromium.org
6 years, 8 months ago (2014-04-03 03:13:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/221613005/60001
6 years, 8 months ago (2014-04-03 03:23:03 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 10:12:36 UTC) #6
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 10:12:37 UTC) #7
horo
The CQ bit was checked by horo@chromium.org
6 years, 8 months ago (2014-04-03 13:44:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/221613005/60001
6 years, 8 months ago (2014-04-03 13:44:52 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 14:51:34 UTC) #10
Message was sent while issue was closed.
Change committed as 261387

Powered by Google App Engine
This is Rietveld 408576698