Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2216123003: Mark Local::As and Persistent::As as const (Closed)

Created:
4 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Mark Local::As and Persistent::As as const Since they are. R=verwaest@chromium.org BUG= Committed: https://crrev.com/682a8f71d85cb7b79e5886800be702633af584fe Cr-Commit-Position: refs/heads/master@{#38386}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M include/v8.h View 1 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
jochen (gone - plz use gerrit)
4 years, 4 months ago (2016-08-05 12:03:30 UTC) #1
jochen (gone - plz use gerrit)
4 years, 4 months ago (2016-08-05 12:19:11 UTC) #7
Camillo Bruni
lgtm
4 years, 4 months ago (2016-08-05 12:20:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216123003/20001
4 years, 4 months ago (2016-08-05 12:20:32 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-05 12:56:40 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 13:00:32 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/682a8f71d85cb7b79e5886800be702633af584fe
Cr-Commit-Position: refs/heads/master@{#38386}

Powered by Google App Engine
This is Rietveld 408576698