Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1373)

Issue 2216113002: Break out of for loop if bisect job succeeds on one test device (Closed)

Created:
4 years, 4 months ago by Ziqi Xiong
Modified:
4 years, 4 months ago
Reviewers:
RobertoCN
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Break out of for loop if bisect job succeeds on one test device Currently if a bisect host has multiple test devices, it will run bisect jobs on all of them. It should stop once one of the test devices finish running the job successfully. BUG=chromium:634533 Committed: https://chromium.googlesource.com/chromium/tools/build/+/ef700964e04ba92356b0d19d6e9aec139718b6b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -15 lines) Patch
M scripts/slave/recipe_modules/auto_bisect/local_bisect.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.py View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_basic_device.json View 17 chunks +111 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Ziqi Xiong
This should fix the repeated bisect jobs.
4 years, 4 months ago (2016-08-04 23:33:56 UTC) #2
RobertoCN
lgtm
4 years, 4 months ago (2016-08-05 00:45:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216113002/1
4 years, 4 months ago (2016-08-05 01:07:38 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 01:11:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/ef700964e04ba92356b0...

Powered by Google App Engine
This is Rietveld 408576698