Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2216093002: fix missing `bool` type annotation on dynamicIsBottom (Closed)

Created:
4 years, 4 months ago by Jennifer Messerly
Modified:
4 years, 4 months ago
Reviewers:
Leaf
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix missing `bool` type annotation on dynamicIsBottom this was causing a strong mode error in the IDE Committed: https://github.com/dart-lang/sdk/commit/98eeba135354440189e7cdcecc75cf94a58a440f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/analyzer/lib/src/generated/type_system.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Jennifer Messerly
TBR
4 years, 4 months ago (2016-08-04 23:05:03 UTC) #3
Jennifer Messerly
Committed patchset #1 (id:1) manually as 98eeba135354440189e7cdcecc75cf94a58a440f (presubmit successful).
4 years, 4 months ago (2016-08-04 23:05:34 UTC) #5
Leaf
4 years, 4 months ago (2016-08-04 23:55:36 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698