third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp - Issue 2216073002: Color: Add ColorCorrectRendering flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp

Issue 2216073002: Color: Add ColorCorrectRendering flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@decoder_profile

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in ('k') | third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp b/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp

index e698232f55096f5d20ba90ca0f4b084e7694f62d..d72bad8ac9f01da0a6fdaee88eaf190ea630efba 100644

--- a/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp

+++ b/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp

@@ -62,8 +62,12 @@ static PassRefPtr<SkSurface> createSkSurface(GrContext* gr, const IntSize& size,

if (gr)

gr->resetContext();

+ sk_sp<SkColorSpace> colorSpace;

+ if (RuntimeEnabledFeatures::colorCorrectRenderingEnabled())

+ colorSpace = SkColorSpace::NewNamed(SkColorSpace::kSRGB_Named);

Justin Novosad 2016/08/05 00:17:06 Actually, could you leave this part out? I have a

ccameron 2016/08/05 00:39:49 Sg -- removed.

SkAlphaType alphaType = (Opaque == opacityMode) ? kOpaque_SkAlphaType : kPremul_SkAlphaType;

- SkImageInfo info = SkImageInfo::MakeN32(size.width(), size.height(), alphaType);

+ SkImageInfo info = SkImageInfo::MakeN32(size.width(), size.height(), alphaType, colorSpace);

SkSurfaceProps disableLCDProps(0, kUnknown_SkPixelGeometry);

sk_sp<SkSurface> surface;