[interpreter] Add register output to ObjectLiteral

[interpreter] Add register output to ObjectLiteral

Avoids the always generated Star bytecodes after ObjectLiteral.

BUG=v4:4820
LOG=n

Committed: https://crrev.com/6c9ef89540f027a625d9d7f87f483f868ba45283
Cr-Commit-Position: refs/heads/master@{#38480}

[klaasb, 2016-08-08 10:01:56]

klaasb@google.com changed reviewers:
+ rmcilroy@chromium.org

[rmcilroy, 2016-08-08 11:40:45]

LGTM, thanks.

https://codereview.chromium.org/2216023003/diff/1/src/compiler/bytecode-graph...
File src/compiler/bytecode-graph-builder.cc (right):

https://codereview.chromium.org/2216023003/diff/1/src/compiler/bytecode-graph...
src/compiler/bytecode-graph-builder.cc:963: FrameStateBeforeAndAfter
states(this);
nit - move this to the top of the function (just ensures that the "before"
checkpoint happens before any operations to do with the bytecode execution).

https://codereview.chromium.org/2216023003/diff/1/src/compiler/bytecode-graph...
src/compiler/bytecode-graph-builder.cc:964: Node* literal = NewNode(op,
GetFunctionClosure());
just inline javascript()->CreateLiteralObject here rather than creating an op
variable

[klaasb, 2016-08-09 08:49:07]

https://codereview.chromium.org/2216023003/diff/1/src/compiler/bytecode-graph...
File src/compiler/bytecode-graph-builder.cc (right):

https://codereview.chromium.org/2216023003/diff/1/src/compiler/bytecode-graph...
src/compiler/bytecode-graph-builder.cc:963: FrameStateBeforeAndAfter
states(this);
On 2016/08/08 11:40:45, rmcilroy wrote:
> nit - move this to the top of the function (just ensures that the "before"
> checkpoint happens before any operations to do with the bytecode execution). 

Done.

https://codereview.chromium.org/2216023003/diff/1/src/compiler/bytecode-graph...
src/compiler/bytecode-graph-builder.cc:964: Node* literal = NewNode(op,
GetFunctionClosure());
On 2016/08/08 11:40:45, rmcilroy wrote:
> just inline javascript()->CreateLiteralObject here rather than creating an op
> variable

Done.

[klaasb, 2016-08-09 08:49:14]

The CQ bit was checked by klaasb@google.com

[klaasb, 2016-08-09 08:49:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2216023003/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2016-08-09 08:49:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 08:52:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 08:52:55]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/21363)

[klaasb, 2016-08-09 09:33:11]

Description was changed from

==========
[interpreter] Add register output to ObjectLiteral

Avoids the always generated Star bytecodes after ObjectLiteral.

BUG=v4:4820
LOG=n
==========

to

==========
[interpreter] Add register output to ObjectLiteral

Avoids the always generated Star bytecodes after ObjectLiteral.

BUG=v4:4820
LOG=n
==========

[klaasb, 2016-08-09 09:33:11]

klaasb@google.com changed reviewers:
+ mstarzinger@chromium.org

[klaasb, 2016-08-09 09:35:14]

Hi Michi,

could you take a short look at the bytecode-graph-builder, please.

[Michael Starzinger, 2016-08-09 09:46:26]

LGTM.

[klaasb, 2016-08-09 09:59:20]

The CQ bit was checked by klaasb@google.com

[commit-bot: I haz the power, 2016-08-09 09:59:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 10:30:12]

Description was changed from

==========
[interpreter] Add register output to ObjectLiteral

Avoids the always generated Star bytecodes after ObjectLiteral.

BUG=v4:4820
LOG=n
==========

to

==========
[interpreter] Add register output to ObjectLiteral

Avoids the always generated Star bytecodes after ObjectLiteral.

BUG=v4:4820
LOG=n
==========

[commit-bot: I haz the power, 2016-08-09 10:30:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-09 10:30:36]

Description was changed from

==========
[interpreter] Add register output to ObjectLiteral

Avoids the always generated Star bytecodes after ObjectLiteral.

BUG=v4:4820
LOG=n
==========

to

==========
[interpreter] Add register output to ObjectLiteral

Avoids the always generated Star bytecodes after ObjectLiteral.

BUG=v4:4820
LOG=n

Committed: https://crrev.com/6c9ef89540f027a625d9d7f87f483f868ba45283
Cr-Commit-Position: refs/heads/master@{#38480}
==========

[commit-bot: I haz the power, 2016-08-09 10:30:37]

Patchset 2 (id:??) landed as
https://crrev.com/6c9ef89540f027a625d9d7f87f483f868ba45283
Cr-Commit-Position: refs/heads/master@{#38480}