chrome/browser/chromeos/login/wizard_controller.cc - Issue 2215993002: Allow changing metrics reporting state without callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/wizard_controller.cc

Issue 2215993002: Allow changing metrics reporting state without callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/wizard_controller.h ('k') | chrome/browser/metrics/chrome_metrics_service_accessor.h » ('j') | chrome/browser/metrics/metrics_reporting_state.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/wizard_controller.cc

diff --git a/chrome/browser/chromeos/login/wizard_controller.cc b/chrome/browser/chromeos/login/wizard_controller.cc

index ee672fd154fd8d107d3c1b2fe0e585cb38fdbaef..c6852dac3daa688b1249f00514ce2c72437870b8 100644

--- a/chrome/browser/chromeos/login/wizard_controller.cc

+++ b/chrome/browser/chromeos/login/wizard_controller.cc

@@ -632,9 +632,9 @@ void WizardController::OnUpdateCompleted() {

void WizardController::OnEulaAccepted() {

time_eula_accepted_ = base::Time::Now();

StartupUtils::MarkEulaAccepted();

- InitiateMetricsReportingChange(

+ ChangeMetricsReportingStateWithReply(

usage_statistics_reporting_,

- base::Bind(&WizardController::InitiateMetricsReportingChangeCallback,

+ base::Bind(&WizardController::OnChangeMetricsReportingState,

weak_factory_.GetWeakPtr()));

PerformPostEulaActions();

@@ -645,7 +645,7 @@ void WizardController::OnEulaAccepted() {

}

-void WizardController::InitiateMetricsReportingChangeCallback(bool enabled) {

+void WizardController::OnChangeMetricsReportingState(bool enabled) {

Ilya Sherman 2016/08/05 03:39:06 nit: Probably name this either "OnDidChange" or "O

gayane -on leave until 09-2017 2016/08/05 17:31:43 Done.

CrosSettings::Get()->SetBoolean(kStatsReportingPref, enabled);

if (!enabled)

return;