Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2215993002: Allow changing metrics reporting state without callback. (Closed)

Created:
4 years, 4 months ago by gayane -on leave until 09-2017
Modified:
4 years, 4 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, asvitkine+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow changing metrics reporting state without callback. Allow changing metrics reporting state without providing callback in cases when the caller doesn't care about the success of the change. Committed: https://crrev.com/8622e36d137eeb9e517b3144c8ee4ff41579c07f Cr-Commit-Position: refs/heads/master@{#410375}

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Patch Set 3 : fix func name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -29 lines) Patch
M chrome/browser/chromeos/arc/arc_support_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_accessor.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/metrics/metrics_reporting_state.h View 1 1 chunk +9 lines, -6 lines 0 comments Download
M chrome/browser/metrics/metrics_reporting_state.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/first_run_dialog.mm View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/first_run_dialog.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/session_crashed_bubble_view.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 27 (16 generated)
gayane -on leave until 09-2017
Please have a look
4 years, 4 months ago (2016-08-04 20:34:51 UTC) #4
Ilya Sherman
LGTM % nits, thanks. https://codereview.chromium.org/2215993002/diff/1/chrome/browser/chromeos/login/wizard_controller.cc File chrome/browser/chromeos/login/wizard_controller.cc (right): https://codereview.chromium.org/2215993002/diff/1/chrome/browser/chromeos/login/wizard_controller.cc#newcode648 chrome/browser/chromeos/login/wizard_controller.cc:648: void WizardController::OnChangeMetricsReportingState(bool enabled) { nit: ...
4 years, 4 months ago (2016-08-05 03:39:06 UTC) #5
gayane -on leave until 09-2017
Thanks for the review. https://codereview.chromium.org/2215993002/diff/1/chrome/browser/chromeos/login/wizard_controller.cc File chrome/browser/chromeos/login/wizard_controller.cc (right): https://codereview.chromium.org/2215993002/diff/1/chrome/browser/chromeos/login/wizard_controller.cc#newcode648 chrome/browser/chromeos/login/wizard_controller.cc:648: void WizardController::OnChangeMetricsReportingState(bool enabled) { On ...
4 years, 4 months ago (2016-08-05 17:31:43 UTC) #6
gayane -on leave until 09-2017
stevenjb@chromium.org: Please have a look for owners review for chrome/browser/ui/webui/options/browser_options_handler.cc thestig@chromium.org: Please have a look ...
4 years, 4 months ago (2016-08-05 17:36:16 UTC) #8
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-05 17:45:40 UTC) #10
stevenjb
chrome/browser/ui/webui lgtm
4 years, 4 months ago (2016-08-05 19:55:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2215993002/20001
4 years, 4 months ago (2016-08-05 20:31:07 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/179054)
4 years, 4 months ago (2016-08-05 20:45:33 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2215993002/40001
4 years, 4 months ago (2016-08-08 15:46:02 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-08 16:26:45 UTC) #25
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 16:31:29 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8622e36d137eeb9e517b3144c8ee4ff41579c07f
Cr-Commit-Position: refs/heads/master@{#410375}

Powered by Google App Engine
This is Rietveld 408576698