Allow changing metrics reporting state without callback.

Allow changing metrics reporting state without callback.

Allow changing metrics reporting state without providing
callback in cases when the caller doesn't care about the
success of the change.

Committed: https://crrev.com/8622e36d137eeb9e517b3144c8ee4ff41579c07f
Cr-Commit-Position: refs/heads/master@{#410375}

[gayane -on leave until 09-2017, 2016-08-04 20:34:09]

Description was changed from

==========
Allow changing metrics reporting state without callback.
==========

to

==========
Allow changing metrics reporting state without callback.


Allow changing metrics reporting state without providing callback in cases when
the caller doesn't care about the success of the change.
==========

[gayane -on leave until 09-2017, 2016-08-04 20:34:10]

gayane@chromium.org changed reviewers:
+ isherman@chromium.org

[gayane -on leave until 09-2017, 2016-08-04 20:34:29]

Description was changed from

==========
Allow changing metrics reporting state without callback.


Allow changing metrics reporting state without providing callback in cases when
the caller doesn't care about the success of the change.
==========

to

==========
Allow changing metrics reporting state without callback.


Allow changing metrics reporting state without providing
callback in cases when the caller doesn't care about the
success of the change.
==========

[gayane -on leave until 09-2017, 2016-08-04 20:34:51]

Please have a look

[Ilya Sherman, 2016-08-05 03:39:06]

LGTM % nits, thanks.

https://codereview.chromium.org/2215993002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/wizard_controller.cc (right):

https://codereview.chromium.org/2215993002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/wizard_controller.cc:648: void
WizardController::OnChangeMetricsReportingState(bool enabled) {
nit: Probably name this either "OnDidChange" or "OnChanged"

https://codereview.chromium.org/2215993002/diff/1/chrome/browser/metrics/metr...
File chrome/browser/metrics/metrics_reporting_state.cc (right):

https://codereview.chromium.org/2215993002/diff/1/chrome/browser/metrics/metr...
chrome/browser/metrics/metrics_reporting_state.cc:105: }
nit: Please define this in the same order in the .cc file as in the .h file.

[gayane -on leave until 09-2017, 2016-08-05 17:31:43]

Thanks for the review.

https://codereview.chromium.org/2215993002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/wizard_controller.cc (right):

https://codereview.chromium.org/2215993002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/wizard_controller.cc:648: void
WizardController::OnChangeMetricsReportingState(bool enabled) {
On 2016/08/05 03:39:06, Ilya Sherman wrote:
> nit: Probably name this either "OnDidChange" or "OnChanged"

Done.

https://codereview.chromium.org/2215993002/diff/1/chrome/browser/metrics/metr...
File chrome/browser/metrics/metrics_reporting_state.cc (right):

https://codereview.chromium.org/2215993002/diff/1/chrome/browser/metrics/metr...
chrome/browser/metrics/metrics_reporting_state.cc:105: }
On 2016/08/05 03:39:06, Ilya Sherman wrote:
> nit: Please define this in the same order in the .cc file as in the .h file.

Done.

[gayane -on leave until 09-2017, 2016-08-05 17:36:16]

gayane@chromium.org changed reviewers:
+ stevenjb@chromium.org, thestig@chromium.org

[gayane -on leave until 09-2017, 2016-08-05 17:36:16]

stevenjb@chromium.org: Please have a look for owners review for
chrome/browser/ui/webui/options/browser_options_handler.cc

thestig@chromium.org: Please have a look for owners review for 
chrome/browser/*

[Lei Zhang, 2016-08-05 17:43:48]

Description was changed from

==========
Allow changing metrics reporting state without callback.


Allow changing metrics reporting state without providing
callback in cases when the caller doesn't care about the
success of the change.
==========

to

==========
Allow changing metrics reporting state without callback.

Allow changing metrics reporting state without providing
callback in cases when the caller doesn't care about the
success of the change.
==========

[Lei Zhang, 2016-08-05 17:45:40]

lgtm

[stevenjb, 2016-08-05 19:55:47]

chrome/browser/ui/webui lgtm

[gayane -on leave until 09-2017, 2016-08-05 20:26:56]

The CQ bit was checked by gayane@chromium.org

[gayane -on leave until 09-2017, 2016-08-05 20:26:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2215993002/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2016-08-05 20:31:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 20:45:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 20:45:33]

Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[gayane -on leave until 09-2017, 2016-08-05 21:04:30]

The CQ bit was checked by gayane@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 21:04:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 23:39:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 23:39:30]

Dry run: This issue passed the CQ dry run.

[gayane -on leave until 09-2017, 2016-08-08 15:45:31]

The CQ bit was checked by gayane@chromium.org

[gayane -on leave until 09-2017, 2016-08-08 15:45:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, stevenjb@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2215993002/#ps40001
(title: "fix func name")

[commit-bot: I haz the power, 2016-08-08 15:46:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 16:26:44]

Description was changed from

==========
Allow changing metrics reporting state without callback.

Allow changing metrics reporting state without providing
callback in cases when the caller doesn't care about the
success of the change.
==========

to

==========
Allow changing metrics reporting state without callback.

Allow changing metrics reporting state without providing
callback in cases when the caller doesn't care about the
success of the change.
==========

[commit-bot: I haz the power, 2016-08-08 16:26:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-08 16:31:27]

Description was changed from

==========
Allow changing metrics reporting state without callback.

Allow changing metrics reporting state without providing
callback in cases when the caller doesn't care about the
success of the change.
==========

to

==========
Allow changing metrics reporting state without callback.

Allow changing metrics reporting state without providing
callback in cases when the caller doesn't care about the
success of the change.

Committed: https://crrev.com/8622e36d137eeb9e517b3144c8ee4ff41579c07f
Cr-Commit-Position: refs/heads/master@{#410375}
==========

[commit-bot: I haz the power, 2016-08-08 16:31:29]

Patchset 3 (id:??) landed as
https://crrev.com/8622e36d137eeb9e517b3144c8ee4ff41579c07f
Cr-Commit-Position: refs/heads/master@{#410375}