Add 'didDispatchPingLoader' callback to FrameLoaderClient.

Add 'didDispatchPingLoader' callback to FrameLoaderClient.

Our current <a ping> and CSP violation report layout tests dispatch a
PingLoader to a script that writes to a file, and then navigate to
another script that reads that file and dumps the payload. This works
for most cases, but doesn't allow us to effectively assert that the
number of pings matches the expectations.

Adding a 'didDispatchPingLoader' callback enables visible output in
layout tests when a PingLoader is dispatched to a URL, which makes it
possible to verify that we're sending one and only one ping to a URL.

This will be particularly useful for a future CL which intends to
deduplicate CSP violation reports.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155608

[Mike West, 2013-08-05 09:03:57]

Jochen, mind taking a look at this? I intend to use the callback to make
https://codereview.chromium.org/21789002/ testable.

If you've got a better suggestion, of course, I'd very much like to hear it.
This patch feels like busywork. :(

-mike

[jochen (gone - plz use gerrit), 2013-08-05 09:26:18]

dunno, looks better than writing to a local file

lgtm

[Nate Chapin, 2013-08-05 16:27:35]

On 2013/08/05 09:26:18, jochen wrote:
> dunno, looks better than writing to a local file
> 
> lgtm

So this patch is test-only, but the callback will be used in production code
soon?

[jochen (gone - plz use gerrit), 2013-08-05 16:31:07]

On 2013/08/05 16:27:35, Nate Chapin wrote:
> On 2013/08/05 09:26:18, jochen wrote:
> > dunno, looks better than writing to a local file
> > 
> > lgtm
> 
> So this patch is test-only, but the callback will be used in production code
> soon?

My understand is that this is test-only code, and it will become useful for
writing tests in upcoming CLs (i.e. the upcoming CLs won't use this callback in
production code either)

[Mike West, 2013-08-05 16:45:13]

On 2013/08/05 16:31:07, jochen wrote:

> > So this patch is test-only, but the callback will be used in production code
> > soon?
> 
> My understand is that this is test-only code, and it will become useful for
> writing tests in upcoming CLs (i.e. the upcoming CLs won't use this callback
in
> production code either)

Correct. This is test-only, and I don't plan any "real" use for it. I need some
mechanism for testing https://codereview.chromium.org/21789002/, however, and
this seems like the best option. If you've got other ideas, I'm happy to run
with them instead. :)

-mike

[commit-bot: I haz the power, 2013-08-06 10:37:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/22159002/1

[commit-bot: I haz the power, 2013-08-06 13:04:51]

Change committed as 155608