Add ability to add/edit cookie in Chrome Dev Tool (front-end)

Editing cookies from the Application>Storage>Cookies panel.

Preview: https://imgur.com/a/njD3J

[kdzwinel, 2016-08-04 13:50:19]

Description was changed from

==========
Fix closure compiler errors.


WIP


WIP


Fix tooltip for creation node


WIP


WIP


WIP

BUG=
==========

to

==========
This is work in progress.
==========

[kdzwinel, 2016-08-05 15:19:30]

Description was changed from

==========
This is work in progress.
==========

to

==========
This is work in progress.

Things that work:
- editing, adding & removing cookies
- receiving debugging protocol events and calling appropriate methods

Things that need work:
- updating DataGrid instead of constantly rebuilding it
- clean up of CookiesTable._saveCookie - this logic should be kept elsewhere
- checkbox DataGrid input (for 'secure' and 'httpOnly' fields)
- select DataGrid input (for 'sameSite' field)
==========

[kdzwinel, 2016-08-05 15:39:44]

Description was changed from

==========
This is work in progress.

Things that work:
- editing, adding & removing cookies
- receiving debugging protocol events and calling appropriate methods

Things that need work:
- updating DataGrid instead of constantly rebuilding it
- clean up of CookiesTable._saveCookie - this logic should be kept elsewhere
- checkbox DataGrid input (for 'secure' and 'httpOnly' fields)
- select DataGrid input (for 'sameSite' field)
==========

to

==========
This is work in progress.

Things that work:
- editing, adding & removing cookies
- receiving debugging protocol events and calling appropriate methods

Things that need work:
- ! updating DataGrid instead of constantly rebuilding it
- ! clean up of CookiesTable._saveCookie - this logic should be kept elsewhere
- checkbox DataGrid input (for 'secure' and 'httpOnly' fields)
- select DataGrid input (for 'sameSite' field)
- decide what to do with cookies being created by user that do not match current
domain
==========

[kdzwinel, 2016-08-17 00:35:08]

Description was changed from

==========
This is work in progress.

Things that work:
- editing, adding & removing cookies
- receiving debugging protocol events and calling appropriate methods

Things that need work:
- ! updating DataGrid instead of constantly rebuilding it
- ! clean up of CookiesTable._saveCookie - this logic should be kept elsewhere
- checkbox DataGrid input (for 'secure' and 'httpOnly' fields)
- select DataGrid input (for 'sameSite' field)
- decide what to do with cookies being created by user that do not match current
domain
==========

to

==========
This is work in progress.

Things that work:
- editing, adding & removing cookies
- receiving debugging protocol events and calling appropriate methods

Things that need work:
- ! clean up of CookiesTable._saveCookie - this logic should be kept elsewhere
- ! new & updated cookies are not being automatically sorted
- data validation?
- undoing changes on back-end error?
- checkbox DataGrid input (for 'secure' and 'httpOnly' fields)
- select DataGrid input (for 'sameSite' field)
==========

[kdzwinel, 2016-08-17 00:51:05]

Description was changed from

==========
This is work in progress.

Things that work:
- editing, adding & removing cookies
- receiving debugging protocol events and calling appropriate methods

Things that need work:
- ! clean up of CookiesTable._saveCookie - this logic should be kept elsewhere
- ! new & updated cookies are not being automatically sorted
- data validation?
- undoing changes on back-end error?
- checkbox DataGrid input (for 'secure' and 'httpOnly' fields)
- select DataGrid input (for 'sameSite' field)
==========

to

==========
This is work in progress.

Things that work:
- editing, adding & removing cookies
- receiving debugging protocol events and calling appropriate methods

Things that need work:
- ! clean up of CookiesTable._saveCookie - this logic should be kept elsewhere
- ! new & updated cookies are not being automatically sorted
- cookies coming with the cookieAdded event are not being filtered by domain
(and end up showing in the current DataGrid even they may not belong there)
- data validation?
- undoing changes on back-end error?
- checkbox DataGrid input (for 'secure' and 'httpOnly' fields)
- select DataGrid input (for 'sameSite' field)
==========

[kdzwinel, 2016-08-17 01:08:40]

Description was changed from

==========
This is work in progress.

Things that work:
- editing, adding & removing cookies
- receiving debugging protocol events and calling appropriate methods

Things that need work:
- ! clean up of CookiesTable._saveCookie - this logic should be kept elsewhere
- ! new & updated cookies are not being automatically sorted
- cookies coming with the cookieAdded event are not being filtered by domain
(and end up showing in the current DataGrid even they may not belong there)
- data validation?
- undoing changes on back-end error?
- checkbox DataGrid input (for 'secure' and 'httpOnly' fields)
- select DataGrid input (for 'sameSite' field)
==========

to

==========
This is work in progress.

Things that work:
- editing, adding & removing cookies
- receiving debugging protocol events and calling appropriate methods

Things that need work:
- ! clean up of CookiesTable._saveCookie - this logic should be kept elsewhere
- ! new & updated cookies are not being automatically sorted
- cookies coming with the cookieAdded event are not being filtered by domain
(and end up showing in the current DataGrid even they may not belong there)
- it's possible to create a cookie with an empty name and value (which shouldn't
be possible)
- data validation?
- undoing changes on back-end error?
- checkbox DataGrid input (for 'secure' and 'httpOnly' fields)
- select DataGrid input (for 'sameSite' field)
==========

[kdzwinel, 2016-08-22 18:41:27]

Description was changed from

==========
This is work in progress.

Things that work:
- editing, adding & removing cookies
- receiving debugging protocol events and calling appropriate methods

Things that need work:
- ! clean up of CookiesTable._saveCookie - this logic should be kept elsewhere
- ! new & updated cookies are not being automatically sorted
- cookies coming with the cookieAdded event are not being filtered by domain
(and end up showing in the current DataGrid even they may not belong there)
- it's possible to create a cookie with an empty name and value (which shouldn't
be possible)
- data validation?
- undoing changes on back-end error?
- checkbox DataGrid input (for 'secure' and 'httpOnly' fields)
- select DataGrid input (for 'sameSite' field)
==========

to

==========
This is work in progress.

Things that need work:
- when editing a cookie with domain "example.com", back-end changes it to
".example.com"
- checkbox DataGrid input (for 'secure' and 'httpOnly' fields)
- select DataGrid input (for 'sameSite' field)
==========

[kdzwinel, 2016-08-23 22:39:41]

Description was changed from

==========
This is work in progress.

Things that need work:
- when editing a cookie with domain "example.com", back-end changes it to
".example.com"
- checkbox DataGrid input (for 'secure' and 'httpOnly' fields)
- select DataGrid input (for 'sameSite' field)
==========

to

==========
This is work in progress.

Things that need work:
- checkbox DataGrid input (for 'secure' and 'httpOnly' fields)
- select DataGrid input (for 'sameSite' field)
==========

[kdzwinel, 2016-08-30 23:05:33]

Description was changed from

==========
This is work in progress.

Things that need work:
- checkbox DataGrid input (for 'secure' and 'httpOnly' fields)
- select DataGrid input (for 'sameSite' field)
==========

to

==========
Editing cookies from the Application>Storage>Cookies panel.

Preview: https://imgur.com/a/njD3J
==========

[allada, 2016-09-01 19:12:46]

Description was changed from

==========
Editing cookies from the Application>Storage>Cookies panel.

Preview: https://imgur.com/a/njD3J
==========

to

==========
Editing cookies from the Application>Storage>Cookies panel.

Preview: https://imgur.com/a/njD3J
==========

[allada, 2016-09-01 19:12:47]

allada@chromium.org changed reviewers:
+ allada@chromium.org

[allada, 2016-09-01 20:54:03]

We should not allow the user to continue tabbing to new lines when last line is
not filled properly... example: http://imgur.com/a/7sLjS

We should refresh the cookies list after the user enters a new cookie to ensure
it got added, if it did not keep the "queued" cookie but show it as not added.


Right now the users are forced to type in all fields in order for it to send to
the server, can we add the cookie as soon as possible then edit it as the user
changes fields from then on? Maybe default the date to +1 year of current time?

[kdzwinel, 2016-09-01 22:30:34]

Thank you for feedback!

> Right now the users are forced to type in all fields in order for it to send
to the server, can we add the cookie as soon as possible then edit it as the
user changes fields from then on? Maybe default the date to +1 year of current
time?

How about defaulting date to "Session"? IMO it's feels less arbitrary than
now+1y. We could also default the domain and path to the target's, WDYT?

> We should not allow the user to continue tabbing to new lines when last line
is not filled properly... example: http://imgur.com/a/7sLjS

Good catch. The reason why this happens is that DataGrid creates a new creation
node as soon as user touches one of the fields of the existing creation node. I
though about introducing validationCallback to the DataGrid which would be
called before editCallback is called and a new creationNode is added preventing
them, if needed, from happening. This however would require calling editCallback
multiple times for all values that have changed when validation finally
succeeds. It felt overcomplicated and I wanted to keep changes to the core
elements (DataGrid) to the minimum. Right now I'm doing validation in the
editCallback, so the uglier but simpler solution would be to remove the
crationNode whenever this validation fails.

> We should refresh the cookies list after the user enters a new cookie to
ensure it got added, if it did not keep the "queued" cookie but show it as not
added.

So the cookie should be "unsaved"/"queued" as long as we don't get back
verification from the back-end that it was saved, right? Will do!

[allada, 2016-09-01 22:38:04]

On 2016/09/01 22:30:34, kdzwinel wrote:
> Thank you for feedback!
> 
> > Right now the users are forced to type in all fields in order for it to send
> to the server, can we add the cookie as soon as possible then edit it as the
> user changes fields from then on? Maybe default the date to +1 year of current
> time?
> 
> How about defaulting date to "Session"? IMO it's feels less arbitrary than
> now+1y. We could also default the domain and path to the target's, WDYT?
I think session cookies are fine.
> 
> > We should not allow the user to continue tabbing to new lines when last line
> is not filled properly... example: http://imgur.com/a/7sLjS
> 
> Good catch. The reason why this happens is that DataGrid creates a new
creation
> node as soon as user touches one of the fields of the existing creation node.
I
> though about introducing validationCallback to the DataGrid which would be
> called before editCallback is called and a new creationNode is added
preventing
> them, if needed, from happening. This however would require calling
editCallback
> multiple times for all values that have changed when validation finally
> succeeds. It felt overcomplicated and I wanted to keep changes to the core
> elements (DataGrid) to the minimum. Right now I'm doing validation in the
> editCallback, so the uglier but simpler solution would be to remove the
> crationNode whenever this validation fails.
> 
> > We should refresh the cookies list after the user enters a new cookie to
> ensure it got added, if it did not keep the "queued" cookie but show it as not
> added.
> 
> So the cookie should be "unsaved"/"queued" as long as we don't get back
> verification from the back-end that it was saved, right? Will do!
Yes I think that is how we should handle it... we want the user to know if the
data is actually there.


I will run it by our UI guy on next revision to see if he wants any other
changes then we'll start the actual code review.

[allada, 2016-12-23 00:41:15]

I am going to close this issue since it's been replaced by:
https://codereview.chromium.org/2567873002/