Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2215713002: [debug] fix exception prediction for asm frames. (Closed)

Created:
4 years, 4 months ago by Yang
Modified:
4 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug] fix exception prediction for asm frames. R=mstarzinger@chromium.org BUG=chromium:633999 Committed: https://crrev.com/771b81f8062cdbfd1ef124909c2d6bb6f8af3084 Cr-Commit-Position: refs/heads/master@{#38358}

Patch Set 1 #

Patch Set 2 : fix flag #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2 lines) Patch
M src/isolate.cc View 1 chunk +9 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-633999.js View 1 2 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Yang
4 years, 4 months ago (2016-08-04 11:19:09 UTC) #1
Michael Starzinger
LGTM. Thanks!
4 years, 4 months ago (2016-08-04 11:35:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2215713002/1
4 years, 4 months ago (2016-08-04 11:40:07 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/1707) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-08-04 11:51:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2215713002/20001
4 years, 4 months ago (2016-08-04 12:00:18 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/1712) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-08-04 12:11:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2215713002/40001
4 years, 4 months ago (2016-08-05 06:39:37 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-05 07:14:03 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 07:14:29 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/771b81f8062cdbfd1ef124909c2d6bb6f8af3084
Cr-Commit-Position: refs/heads/master@{#38358}

Powered by Google App Engine
This is Rietveld 408576698