Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2215693002: [base] Add Decrement and assignment operators to AtomicNumber (Closed)

Created:
4 years, 4 months ago by Michael Lippautz
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[base] Add Decrement and assignment operators to AtomicNumber AtomicNumber should make dealing with atomic counters easier. This is not the case with size_t, as we cannot properly use the Increment() method for negative numbers. With this CL we can use AtomicNumber<size_t> and have proper decrements. R=jochen@chromium.org Committed: https://crrev.com/5e685567ea58d94b033ec67e02bdafa6e45d4544 Cr-Commit-Position: refs/heads/master@{#38407}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M src/base/atomic-utils.h View 2 chunks +10 lines, -1 line 0 comments Download
M test/unittests/base/atomic-utils-unittest.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Michael Lippautz
PTAL Ideally we would at some point switch to using std::atomic ;)
4 years, 4 months ago (2016-08-04 10:26:59 UTC) #1
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-08-05 11:40:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2215693002/1
4 years, 4 months ago (2016-08-07 18:06:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-07 18:29:21 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-07 18:31:16 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e685567ea58d94b033ec67e02bdafa6e45d4544
Cr-Commit-Position: refs/heads/master@{#38407}

Powered by Google App Engine
This is Rietveld 408576698