Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1389)

Unified Diff: Source/core/rendering/compositing/RenderLayerCompositor.cpp

Issue 221563002: Delete RenderLayerCompositor::m_needsToUpdateLayerTreeGeometry (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/compositing/RenderLayerCompositor.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/compositing/RenderLayerCompositor.cpp
diff --git a/Source/core/rendering/compositing/RenderLayerCompositor.cpp b/Source/core/rendering/compositing/RenderLayerCompositor.cpp
index 963600020937b6175ddcde1113bb2883769a440d..2061672aa6ef66ff593fa7a8d486e61630e93bba 100644
--- a/Source/core/rendering/compositing/RenderLayerCompositor.cpp
+++ b/Source/core/rendering/compositing/RenderLayerCompositor.cpp
@@ -202,7 +202,6 @@ RenderLayerCompositor::RenderLayerCompositor(RenderView& renderView)
, m_hasAcceleratedCompositing(true)
, m_showRepaintCounter(false)
, m_needsToRecomputeCompositingRequirements(false)
- , m_needsToUpdateLayerTreeGeometry(false)
, m_compositing(false)
, m_compositingLayersNeedRebuild(false)
, m_forceCompositingMode(false)
@@ -368,21 +367,15 @@ void RenderLayerCompositor::setNeedsCompositingUpdate(CompositingUpdateType upda
break;
case CompositingUpdateAfterStyleChange:
m_needsToRecomputeCompositingRequirements = true;
- m_needsToUpdateLayerTreeGeometry = true;
break;
case CompositingUpdateAfterLayout:
m_needsToRecomputeCompositingRequirements = true;
- m_needsToUpdateLayerTreeGeometry = true;
break;
case CompositingUpdateOnScroll:
m_needsToRecomputeCompositingRequirements = true; // Overlap can change with scrolling, so need to check for hierarchy updates.
- m_needsToUpdateLayerTreeGeometry = true;
break;
case CompositingUpdateOnCompositedScroll:
- m_needsToUpdateLayerTreeGeometry = true;
- break;
case CompositingUpdateAfterCanvasContextChange:
- m_needsToUpdateLayerTreeGeometry = true;
break;
}
@@ -439,7 +432,7 @@ void RenderLayerCompositor::scheduleAnimationIfNeeded()
bool RenderLayerCompositor::hasUnresolvedDirtyBits()
{
- return m_needsToRecomputeCompositingRequirements || m_compositingLayersNeedRebuild || m_needsToUpdateLayerTreeGeometry || m_needsUpdateCompositingRequirementsState || m_pendingUpdateType > CompositingUpdateNone;
+ return m_needsToRecomputeCompositingRequirements || m_compositingLayersNeedRebuild || m_needsUpdateCompositingRequirementsState || m_pendingUpdateType > CompositingUpdateNone;
}
void RenderLayerCompositor::updateCompositingLayersInternal()
@@ -457,10 +450,9 @@ void RenderLayerCompositor::updateCompositingLayersInternal()
bool needCompositingRequirementsUpdate = m_needsToRecomputeCompositingRequirements;
bool needHierarchyAndGeometryUpdate = m_compositingLayersNeedRebuild;
- bool needGeometryUpdate = m_needsToUpdateLayerTreeGeometry;
bool needsToUpdateScrollingCoordinator = scrollingCoordinator() ? scrollingCoordinator()->needsToUpdateAfterCompositingChange() : false;
- if (!needCompositingRequirementsUpdate && !needHierarchyAndGeometryUpdate && !needGeometryUpdate && !needsToUpdateScrollingCoordinator)
+ if (updateType == CompositingUpdateNone && !needCompositingRequirementsUpdate && !needHierarchyAndGeometryUpdate && !needsToUpdateScrollingCoordinator)
return;
m_pendingUpdateType = CompositingUpdateNone;
@@ -476,7 +468,6 @@ void RenderLayerCompositor::updateCompositingLayersInternal()
// Only clear the flags if we're updating the entire hierarchy.
m_compositingLayersNeedRebuild = false;
- m_needsToUpdateLayerTreeGeometry = false;
m_needsToRecomputeCompositingRequirements = false;
RenderLayer* updateRoot = rootRenderLayer();
@@ -527,7 +518,7 @@ void RenderLayerCompositor::updateCompositingLayersInternal()
needHierarchyAndGeometryUpdate = true;
}
- if (needGeometryUpdate || needHierarchyAndGeometryUpdate) {
+ if (updateType >= CompositingUpdateAfterStyleChange || needHierarchyAndGeometryUpdate) {
TRACE_EVENT0("blink_rendering", "GraphicsLayerUpdater::updateRecursive");
GraphicsLayerUpdater().update(*updateRoot, graphicsLayerUpdateType);
#if !ASSERT_DISABLED
« no previous file with comments | « Source/core/rendering/compositing/RenderLayerCompositor.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698