Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 221553009: Tiny cleanUp. (Closed)

Created:
6 years, 8 months ago by merkulova
Modified:
6 years, 8 months ago
Reviewers:
ygorshenin1
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Declaration removed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M chrome/browser/resources/login/display_manager.js View 4 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
merkulova
6 years, 8 months ago (2014-04-02 07:58:11 UTC) #1
ygorshenin1
https://codereview.chromium.org/221553009/diff/1/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (left): https://codereview.chromium.org/221553009/diff/1/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc#oldcode1458 chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:1458: void SigninScreenHandler::HandleNetworkErrorShown() { Could you please also remove declaration ...
6 years, 8 months ago (2014-04-02 08:02:15 UTC) #2
merkulova
6 years, 8 months ago (2014-04-02 08:05:10 UTC) #3
ygorshenin1
lgtm
6 years, 8 months ago (2014-04-02 08:09:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/221553009/20001
6 years, 8 months ago (2014-04-02 08:09:50 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 15:59:38 UTC) #6
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=60352
6 years, 8 months ago (2014-04-02 15:59:38 UTC) #7
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 8 months ago (2014-04-02 16:13:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/221553009/20001
6 years, 8 months ago (2014-04-02 16:13:42 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 22:18:04 UTC) #10
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=60577
6 years, 8 months ago (2014-04-02 22:18:04 UTC) #11
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 8 months ago (2014-04-03 06:19:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/221553009/20001
6 years, 8 months ago (2014-04-03 06:21:35 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 10:03:48 UTC) #14
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 10:03:48 UTC) #15
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 8 months ago (2014-04-03 11:04:24 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/221553009/20001
6 years, 8 months ago (2014-04-03 11:04:59 UTC) #17
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 12:03:03 UTC) #18
Message was sent while issue was closed. 
Change committed as 261359

Powered by Google App Engine
This is Rietveld 408576698