Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 221553002: Move some component's GN build files to main tree. (Closed)

Created:
6 years, 8 months ago by brettw
Modified:
6 years, 8 months ago
Reviewers:
blundell
CC:
chromium-reviews
Visibility:
Public.

Description

Move some component's GN build files to main tree. This moves the files from the shadow tree and updates shared_library -> source_set. This also hooks up //url to the build (the file was already in the right place) BUG= R=blundell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261140

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -69 lines) Patch
M BUILD.gn View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/language_usage_metrics/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + components/navigation_metrics/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + components/onc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + components/startup_metric_utils/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D tools/gn/secondary/components/language_usage_metrics/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
D tools/gn/secondary/components/navigation_metrics/BUILD.gn View 1 chunk +0 lines, -15 lines 0 comments Download
D tools/gn/secondary/components/onc/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/gn/secondary/components/startup_metric_utils/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
6 years, 8 months ago (2014-04-01 22:18:20 UTC) #1
blundell
LGTM Is there documentation somewhere of gn's syntax/semantics, since now people be maintaining gn files?
6 years, 8 months ago (2014-04-02 08:15:48 UTC) #2
brettw
On 2014/04/02 08:15:48, blundell wrote: > LGTM > > Is there documentation somewhere of gn's ...
6 years, 8 months ago (2014-04-02 16:46:45 UTC) #3
brettw
Committed patchset #1 manually as r261140 (presubmit successful).
6 years, 8 months ago (2014-04-02 17:08:19 UTC) #4
blundell
6 years, 8 months ago (2014-04-02 19:28:52 UTC) #5
Message was sent while issue was closed.
On 2014/04/02 16:46:45, brettw wrote:
> On 2014/04/02 08:15:48, blundell wrote:
> > LGTM
> > 
> > Is there documentation somewhere of gn's syntax/semantics, since now people
be
> > maintaining gn files?
> 
> Yes!
> 
> https://code.google.com/p/chromium/wiki/GNCookbook

Nice!

Powered by Google App Engine
This is Rietveld 408576698