runtime/vm/profiler.cc - Issue 2215523002: Fix for issue 27019 (Safepoint assertion failure in Flutter)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/profiler.cc

Issue 2215523002: Fix for issue 27019 (Safepoint assertion failure in Flutter) (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/profiler.cc

diff --git a/runtime/vm/profiler.cc b/runtime/vm/profiler.cc

index 21b8bf80871d4a778e0b9d3ea6951737ae2bb552..b8827c58e7f1109068c6035ea041db8114e01ae2 100644

--- a/runtime/vm/profiler.cc

+++ b/runtime/vm/profiler.cc

@@ -949,7 +949,9 @@ static uintptr_t __attribute__((noinline)) GetProgramCounter() {

void Profiler::DumpStackTrace(bool native_stack_trace) {

Thread* thread = Thread::Current();

- ASSERT(thread != NULL);

+ if (thread == NULL) {

+ return;

+ }

OSThread* os_thread = thread->os_thread();

ASSERT(os_thread != NULL);

Isolate* isolate = thread->isolate();

« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/thread.cc » ('j') | no next file with comments »