Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 22155003: Return start/end profiling time in microseconds instead of milliseconds (Closed)

Created:
7 years, 4 months ago by yurys
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Return start/end profiling time in microseconds instead of milliseconds The start and end time are now measured in microseconds and the type is int64_t. This way it seems more natural as we are going to support submilisecond sampling rate soon. Also it fixes cctest/test-cpu-profiler/ProfileStartEndTime test failure caused by comparison between long double and double. TEST=cctest/test-cpu-profiler/ProfileStartEndTime BUG=v8:2824 R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M include/v8-profiler.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/api.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/profile-generator.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/profile-generator.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
This is the same as r16049 but with the Win32 compilation fixed (type of time_before_profiling ...
7 years, 4 months ago (2013-08-05 12:36:56 UTC) #1
Benedikt Meurer
Forwarding to danno
7 years, 4 months ago (2013-08-05 12:40:27 UTC) #2
yurys
@danno: can you take a look please? I've got some Blink changes pending this CL.
7 years, 4 months ago (2013-08-06 07:04:02 UTC) #3
Benedikt Meurer
LGTM
7 years, 4 months ago (2013-08-06 07:41:06 UTC) #4
yurys
7 years, 4 months ago (2013-08-06 08:01:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r16067 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698