Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2215443003: [recipes] Increase test coverage (Closed)

Created:
4 years, 4 months ago by borenet2
Modified:
4 years, 4 months ago
Reviewers:
borenet, rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@merge_buildbot_spec
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

[recipes] Increase test coverage Remove a bunch of "pragma: no cover" by removing unused code or adding test bots to cover. BUG=skia:5578 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215443003 Committed: https://skia.googlesource.com/skia/+/2c3112d517720cbc65734004b41131b7369bb517

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1210 lines, -1040 lines) Patch
D infra/bots/recipe_modules/core/android_devices.py View 1 chunk +0 lines, -99 lines 1 comment Download
D infra/bots/recipe_modules/core/ssh_devices.py View 1 chunk +0 lines, -30 lines 1 comment Download
M infra/bots/recipe_modules/flavor/api.py View 1 chunk +0 lines, -3 lines 0 comments Download
M infra/bots/recipe_modules/flavor/default_flavor.py View 2 chunks +0 lines, -7 lines 0 comments Download
M infra/bots/recipe_modules/flavor/ios_flavor.py View 2 chunks +1 line, -11 lines 0 comments Download
M infra/bots/recipe_modules/vars/api.py View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.py View 7 chunks +16 lines, -22 lines 0 comments Download
A + infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-Arm7-Debug-Android_FrameworkDefs.json View 5 chunks +11 lines, -11 lines 0 comments Download
A + infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-Arm7-Debug-Android_NoNeon.json View 6 chunks +11 lines, -11 lines 0 comments Download
A + infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE.json View 4 chunks +6 lines, -5 lines 0 comments Download
A + infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-ANGLE.json View 4 chunks +5 lines, -5 lines 0 comments Download
A + infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-Fast.json View 4 chunks +5 lines, -5 lines 0 comments Download
A + infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-Mesa.json View 4 chunks +5 lines, -5 lines 0 comments Download
A + infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86-Debug-Exceptions.json View 4 chunks +5 lines, -5 lines 0 comments Download
A + infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86-Release-GDI.json View 4 chunks +9 lines, -9 lines 0 comments Download
M infra/bots/recipes/swarm_perf.py View 6 chunks +17 lines, -17 lines 0 comments Download
A + infra/bots/recipes/swarm_perf.expected/Perf-Android-GCC-GalaxyS3-GPU-Mali400-Arm7-Release.json View 9 chunks +7 lines, -100 lines 0 comments Download
A + infra/bots/recipes/swarm_perf.expected/Perf-Android-GCC-NVIDIA_Shield-GPU-TegraX1-Arm64-Debug-Vulkan.json View 24 chunks +26 lines, -147 lines 0 comments Download
A + infra/bots/recipes/swarm_perf.expected/Perf-Android-GCC-Nexus5-GPU-Adreno330-Arm7-Debug.json View 24 chunks +25 lines, -135 lines 0 comments Download
A + infra/bots/recipes/swarm_perf.expected/Perf-Android-GCC-Nexus6-GPU-Adreno420-Arm7-Release.json View 4 chunks +5 lines, -4 lines 0 comments Download
A + infra/bots/recipes/swarm_perf.expected/Perf-Android-GCC-NexusPlayer-GPU-PowerVR-x86-Release.json View 5 chunks +10 lines, -9 lines 0 comments Download
A + infra/bots/recipes/swarm_perf.expected/Perf-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-GN.json View 7 chunks +15 lines, -16 lines 0 comments Download
A infra/bots/recipes/swarm_perf.expected/Perf-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug.json View 1 chunk +328 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.py View 6 chunks +29 lines, -29 lines 0 comments Download
A + infra/bots/recipes/swarm_test.expected/Test-Android-GCC-AndroidOne-GPU-Mali400MP2-Arm7-Release.json View 32 chunks +37 lines, -34 lines 0 comments Download
A + infra/bots/recipes/swarm_test.expected/Test-Android-GCC-NVIDIA_Shield-GPU-TegraX1-Arm64-Debug.json View 4 chunks +10 lines, -7 lines 0 comments Download
A + infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus10-GPU-MaliT604-Arm7-Release.json View 32 chunks +37 lines, -34 lines 0 comments Download
A + infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus6-GPU-Adreno420-Arm7-Debug.json View 3 chunks +5 lines, -3 lines 0 comments Download
A + infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus9-CPU-Denver-Arm64-Debug.json View 4 chunks +10 lines, -20 lines 0 comments Download
A + infra/bots/recipes/swarm_test.expected/Test-Android-GCC-NexusPlayer-CPU-SSE4-x86-Release.json View 30 chunks +40 lines, -132 lines 0 comments Download
A + infra/bots/recipes/swarm_test.expected/Test-Mac-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug.json View 5 chunks +140 lines, -20 lines 0 comments Download
A + infra/bots/recipes/swarm_test.expected/Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Debug.json View 4 chunks +39 lines, -17 lines 0 comments Download
A + infra/bots/recipes/swarm_test.expected/Test-Mac-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug-CommandBuffer.json View 4 chunks +135 lines, -29 lines 0 comments Download
A + infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug.json View 3 chunks +4 lines, -3 lines 0 comments Download
A + infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN.json View 4 chunks +6 lines, -7 lines 0 comments Download
A + infra/bots/recipes/swarm_test.expected/Test-Win10-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug-Vulkan.json View 5 chunks +105 lines, -32 lines 0 comments Download
A + infra/bots/recipes/swarm_test.expected/Test-Win8-MSVC-ShuttleB-GPU-GTX960-x86_64-Debug-ANGLE.json View 7 chunks +105 lines, -16 lines 0 comments Download

Depends on Patchset:

Issue 2205473002 Patch 70001

Messages

Total messages: 9 (5 generated)
borenet
https://codereview.chromium.org/2215443003/diff/1/infra/bots/recipe_modules/core/android_devices.py File infra/bots/recipe_modules/core/android_devices.py (left): https://codereview.chromium.org/2215443003/diff/1/infra/bots/recipe_modules/core/android_devices.py#oldcode1 infra/bots/recipe_modules/core/android_devices.py:1: #!/usr/bin/env python Not sure why this file was still ...
4 years, 4 months ago (2016-08-04 19:33:17 UTC) #4
rmistry
lgtm
4 years, 4 months ago (2016-08-04 19:51:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2215443003/1
4 years, 4 months ago (2016-08-05 13:08:51 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 13:30:13 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2c3112d517720cbc65734004b41131b7369bb517

Powered by Google App Engine
This is Rietveld 408576698