Rework default GN symbol handling for win goma builds.

build/config/compiler/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/chrome_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/nacl/config.gni")
 import("//build/toolchain/cc_wrapper.gni")
 import("//build/toolchain/toolchain.gni")
@@ skipping 1466 matching lines @@
 # You can override the symbol level on a per-target basis by removing the
 # default config and then adding the named one you want:
 #
 #   configs -= [ "//build/config/compiler:default_symbols" ]
 #   configs += [ "//build/config/compiler:symbols" ]
 
 # Full symbols.
 config("symbols") {
   if (is_win) {
     import("//build/toolchain/goma.gni")
-    if (use_goma) {
-      # Disable symbols during goma compilation because otherwise the redundant
-      # debug information (repeated in every .obj file) makes linker memory
-      # consumption and link times unsustainable (crbug.com/630074).
-      cflags = []
-    } else {
-      cflags = [ "/Zi" ]  # Produce PDB file, no edit and continue.
-    }
+    cflags = [ "/Zi" ]  # Produce PDB file, no edit and continue.
+
     if (is_win_fastlink && visual_studio_version != "2013") {
       # Tell VS 2015+ to create a PDB that references debug
       # information in .obj and .lib files instead of copying
       # it all. This flag is incompatible with /PROFILE
       ldflags = [ "/DEBUG:FASTLINK" ]
     } else {
       ldflags = [ "/DEBUG" ]
     }
   } else {
     if (is_mac || is_ios) {
@@ skipping 48 matching lines @@
   }
 }
 
 # Default symbols.
 config("default_symbols") {
   if (symbol_level == 0) {
     configs = [ ":no_symbols" ]
   } else if (symbol_level == 1) {
     configs = [ ":minimal_symbols" ]
   } else if (symbol_level == 2) {
+    assert(
+        !(is_win && use_goma),

[Reid Kleckner, 2016/08/13 01:55:27]

I'd like it if you tossed in '&& !is_clang' so that you can build with
'is_clang=true use_goma=true symbol_level=2' and get a full symbols.

Goma will not make linking clang-built objects any slower or faster, since clang
aliases /Zi to /Z7. Our link times with /Z7 aren't particularly good, but they
aren't as bad as MSVC's, probably because we emit less stuff.

[Dirk Pranke, 2016/08/14 23:34:58]

Okay, will do.

At the moment, I'm actually leaning to removing the assert altogether and seeing
what happens.

+        "Cannot generate full symbols on windows with goma, use " +
+            "symbol_level=1 or compile locally without goma, which will be " +
+            "faster anyway.")
     configs = [ ":symbols" ]
   } else {
     assert(false)
   }
 }
 
 if (is_ios || is_mac) {
   # On Mac and iOS, this enables support for ARC (automatic ref-counting).
   # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
   config("enable_arc") {
     common_flags = [ "-fobjc-arc" ]
     cflags_objc = common_flags
     cflags_objcc = common_flags
   }
 }