Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2215433002: Rework default GN symbol handling for win goma builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge, clean up w/ clang review feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/compiler.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 1490 matching lines...) Expand 10 before | Expand all | Expand 10 after
1501 # You can override the symbol level on a per-target basis by removing the 1501 # You can override the symbol level on a per-target basis by removing the
1502 # default config and then adding the named one you want: 1502 # default config and then adding the named one you want:
1503 # 1503 #
1504 # configs -= [ "//build/config/compiler:default_symbols" ] 1504 # configs -= [ "//build/config/compiler:default_symbols" ]
1505 # configs += [ "//build/config/compiler:symbols" ] 1505 # configs += [ "//build/config/compiler:symbols" ]
1506 1506
1507 # Full symbols. 1507 # Full symbols.
1508 config("symbols") { 1508 config("symbols") {
1509 if (is_win) { 1509 if (is_win) {
1510 import("//build/toolchain/goma.gni") 1510 import("//build/toolchain/goma.gni")
1511 if (use_goma) { 1511 cflags = [ "/Zi" ] # Produce PDB file, no edit and continue.
1512 # Disable symbols during goma compilation because otherwise the redundant 1512
1513 # debug information (repeated in every .obj file) makes linker memory
1514 # consumption and link times unsustainable (crbug.com/630074).
1515 cflags = []
1516 } else {
1517 cflags = [ "/Zi" ] # Produce PDB file, no edit and continue.
1518 }
1519 if (is_win_fastlink && visual_studio_version != "2013") { 1513 if (is_win_fastlink && visual_studio_version != "2013") {
1520 # Tell VS 2015+ to create a PDB that references debug 1514 # Tell VS 2015+ to create a PDB that references debug
1521 # information in .obj and .lib files instead of copying 1515 # information in .obj and .lib files instead of copying
1522 # it all. This flag is incompatible with /PROFILE 1516 # it all. This flag is incompatible with /PROFILE
1523 ldflags = [ "/DEBUG:FASTLINK" ] 1517 ldflags = [ "/DEBUG:FASTLINK" ]
1524 } else { 1518 } else {
1525 ldflags = [ "/DEBUG" ] 1519 ldflags = [ "/DEBUG" ]
1526 } 1520 }
1527 } else { 1521 } else {
1528 if (is_mac || is_ios) { 1522 if (is_mac || is_ios) {
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
1592 1586
1593 if (is_ios || is_mac) { 1587 if (is_ios || is_mac) {
1594 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1588 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1595 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1589 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1596 config("enable_arc") { 1590 config("enable_arc") {
1597 common_flags = [ "-fobjc-arc" ] 1591 common_flags = [ "-fobjc-arc" ]
1598 cflags_objc = common_flags 1592 cflags_objc = common_flags
1599 cflags_objcc = common_flags 1593 cflags_objcc = common_flags
1600 } 1594 }
1601 } 1595 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/compiler.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698