Fix element visibility check for validation bubbles and SELECT popups.

third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
@@ skipping 100 matching lines @@
 }
 
 void ValidationMessageClientImpl::checkAnchorStatus(TimerBase*)
 {
     DCHECK(m_currentAnchor);
     if (monotonicallyIncreasingTime() >= m_finishTime || !currentView()) {
         hideValidationMessage(*m_currentAnchor);
         return;
     }
 
-    // Check the visibility of the element.
-    // FIXME: Can we check invisibility by scrollable non-frame elements?
-    IntRect newAnchorRectInViewport = currentView()->contentsToViewport(m_currentAnchor->pixelSnappedBoundingBox());
-
-    // FIXME: This intersection eliminates the part of the rect outside the root view.
-    // If this is meant as a visiblity test, intersecting it against the viewport rect
-    // likely makes more sense.
-    newAnchorRectInViewport = intersection(currentView()->convertToRootFrame(currentView()->boundsRect()), newAnchorRectInViewport);
+    IntRect newAnchorRectInViewport = m_currentAnchor->visibleBoundsInVisualViewport();
     if (newAnchorRectInViewport.isEmpty()) {
         hideValidationMessage(*m_currentAnchor);
         return;
     }
 
     IntRect newAnchorRectInViewportInScreen = currentView()->getHostWindow()->viewportToScreen(newAnchorRectInViewport, currentView());
     if (newAnchorRectInViewportInScreen == m_lastAnchorRectInScreen && m_webView.pageScaleFactor() == m_lastPageScaleFactor)
         return;
     m_lastAnchorRectInScreen = newAnchorRectInViewportInScreen;
     m_lastPageScaleFactor = m_webView.pageScaleFactor();
     m_webView.client()->moveValidationMessage(newAnchorRectInViewport);
 }
 
 void ValidationMessageClientImpl::willBeDestroyed()
 {
     if (m_currentAnchor)
         hideValidationMessage(*m_currentAnchor);
 }
 
 DEFINE_TRACE(ValidationMessageClientImpl)
 {
     visitor->trace(m_currentAnchor);
     ValidationMessageClient::trace(visitor);
 }
 
 } // namespace blink