Fix element visibility check for validation bubbles and SELECT popups.

third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

 /*
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
@@ skipping 1804 matching lines @@
     if (const ComputedStyle* style = itemComputedStyle(element))
         return style->display() == NONE;
     return false;
 }
 
 const ComputedStyle* HTMLSelectElement::itemComputedStyle(Element& element) const
 {
     return element.computedStyle() ? element.computedStyle() : element.ensureComputedStyle();
 }
 
-IntRect HTMLSelectElement::elementRectRelativeToViewport() const
-{
-    if (!layoutObject())
-        return IntRect();
-    // Initialize with this frame rectangle relative to the viewport.
-    IntRect rect = document().view()->convertToRootFrame(document().view()->boundsRect());
-    // We don't use absoluteBoundingBoxRect() because it can return an IntRect
-    // larger the actual size by 1px.
-    rect.intersect(document().view()->contentsToViewport(roundedIntRect(layoutObject()->absoluteBoundingBoxFloatRect())));
-    return rect;
-}
-
 LayoutUnit HTMLSelectElement::clientPaddingLeft() const
 {
     if (layoutObject() && layoutObject()->isMenuList())
         return toLayoutMenuList(layoutObject())->clientPaddingLeft();
     return LayoutUnit();
 }
 
 LayoutUnit HTMLSelectElement::clientPaddingRight() const
 {
     if (layoutObject() && layoutObject()->isMenuList())
@@ skipping 66 matching lines @@
 }
 
 void HTMLSelectElement::showPopup()
 {
     if (popupIsVisible())
         return;
     if (document().frameHost()->chromeClient().hasOpenedPopup())
         return;
     if (!layoutObject() || !layoutObject()->isMenuList())
         return;
-    // Disable visibility check on Android.  elementRectRelativeToViewport()
-    // doesn't work well on Android WebView.  crbug.com/632561
-#if !OS(ANDROID)
-    if (elementRectRelativeToViewport().isEmpty())
+    if (visibleBoundsInVisualViewport().isEmpty())
         return;
-#endif
 
     if (!m_popup)
         m_popup = document().frameHost()->chromeClient().openPopupMenu(*document().frame(), *this);
     m_popupIsVisible = true;
     observeTreeMutation();
 
     LayoutMenuList* menuList = toLayoutMenuList(layoutObject());
     m_popup->show();
     if (AXObjectCache* cache = document().existingAXObjectCache())
         cache->didShowMenuListPopup(menuList);
@@ skipping 100 matching lines @@
 }
 
 void HTMLSelectElement::didMutateSubtree()
 {
     DCHECK(popupIsVisible());
     DCHECK(m_popup);
     m_popup->updateFromElement(PopupMenu::ByDOMChange);
 }
 
 } // namespace blink