Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.h

Issue 2215333002: Fix element visibility check for validation bubbles and SELECT popups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename to visibleBoundsInVisualViewport(), etc. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Element.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2003-2011, 2013, 2014 Apple Inc. All rights reserved. 6 * Copyright (C) 2003-2011, 2013, 2014 Apple Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 void setScrollTop(double); 213 void setScrollTop(double);
214 int scrollWidth(); 214 int scrollWidth();
215 int scrollHeight(); 215 int scrollHeight();
216 216
217 void scrollBy(double x, double y); 217 void scrollBy(double x, double y);
218 virtual void scrollBy(const ScrollToOptions&); 218 virtual void scrollBy(const ScrollToOptions&);
219 void scrollTo(double x, double y); 219 void scrollTo(double x, double y);
220 virtual void scrollTo(const ScrollToOptions&); 220 virtual void scrollTo(const ScrollToOptions&);
221 221
222 IntRect boundsInViewport() const; 222 IntRect boundsInViewport() const;
223 // Returns an intersection rectangle of the bounds rectangle and the
224 // viewport rectangle, in the visual viewport coordinate. This function is
225 // used to show popups beside this element.
226 IntRect visibleBoundsInVisualViewport() const;
223 227
224 ClientRectList* getClientRects(); 228 ClientRectList* getClientRects();
225 ClientRect* getBoundingClientRect(); 229 ClientRect* getBoundingClientRect();
226 230
227 bool hasNonEmptyLayoutSize() const; 231 bool hasNonEmptyLayoutSize() const;
228 232
229 const AtomicString& computedRole(); 233 const AtomicString& computedRole();
230 String computedName(); 234 String computedName();
231 235
232 void didMoveToNewDocument(Document&) override; 236 void didMoveToNewDocument(Document&) override;
(...skipping 743 matching lines...) Expand 10 before | Expand all | Expand 10 after
976 static T* create(const QualifiedName&, Document&) 980 static T* create(const QualifiedName&, Document&)
977 #define DEFINE_ELEMENT_FACTORY_WITH_TAGNAME(T) \ 981 #define DEFINE_ELEMENT_FACTORY_WITH_TAGNAME(T) \
978 T* T::create(const QualifiedName& tagName, Document& document) \ 982 T* T::create(const QualifiedName& tagName, Document& document) \
979 { \ 983 { \
980 return new T(tagName, document); \ 984 return new T(tagName, document); \
981 } 985 }
982 986
983 } // namespace blink 987 } // namespace blink
984 988
985 #endif // Element_h 989 #endif // Element_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Element.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698