third_party/WebKit/Source/web/tests/data/viewport-select.html - Issue 2215333002: Fix element visibility check for validation bubbles and SELECT popups.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/web/tests/data/viewport-select.html

Issue 2215333002: Fix element visibility check for validation bubbles and SELECT popups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <meta name="viewport" content="minimum-scale=2.0">
	bokan 2016/08/08 15:23:00 The test would be more clear if you remove this me The test would be more clear if you remove this meta tag and just use webViewImpl->setPageScaleFactor(2.0f) in the test itself. tkent 2016/08/09 03:17:12 We need to apply minimum-scale for crbug.com/63256 Show quoted text On 2016/08/08 at 15:23:00, bokan wrote: > The test would be more clear if you remove this meta tag and just use webViewImpl->setPageScaleFactor(2.0f) in the test itself. We need to apply minimum-scale for crbug.com/632561, and WebViewImpl::setDefaultPageScaleLimits(2.0, ...) didn't reproduce the problem.
	5 <style>

	6 select {

	7 position: absolute;

	8 right: 0px;

	9 bottom: 0px;

	10 width: 100px;

	11 height: 20px;

	12 }

	13 </style>

	14 </head>

	15 <body>

	16 <select><option>abc</option></select>

	17 </body>

	18 </html>

OLD	NEW

« third_party/WebKit/Source/web/tests/VisualViewportTest.cpp ('K') | « third_party/WebKit/Source/web/tests/VisualViewportTest.cpp ('k') | no next file » | no next file with comments »