Fix element visibility check for validation bubbles and SELECT popups.

third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/frame/VisualViewport.h"
 
 #include "core/dom/Document.h"
 #include "core/frame/FrameHost.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
@@ skipping 1526 matching lines @@
     IntRect expectedBounds = bounds;
     expectedBounds.scale(2.f);
     IntPoint expectedScrollDelta = scrollDelta;
     expectedScrollDelta.scale(2.f, 2.f);
 
     EXPECT_POINT_EQ(IntPoint(expectedBounds.location() - expectedScrollDelta),
         boundsInViewport.location());
     EXPECT_SIZE_EQ(expectedBounds.size(), boundsInViewport.size());
 }
 
+TEST_P(ParameterizedVisualViewportTest, ElementVisibleBoundsInViewport)
+{
+    initializeWithAndroidSettings();
+    webViewImpl()->resize(IntSize(640, 1080));
+    registerMockedHttpURLLoad("viewport-select.html");
+    navigateTo(m_baseURL + "viewport-select.html");
+
+    webViewImpl()->setInitialFocus(false);
+    Element* element = webViewImpl()->focusedElement();
+    EXPECT_FALSE(element->visibleBoundsInViewport().isEmpty());

[bokan, 2016/08/08 15:22:59]

Please add the converse of this check above before the setInitialFocus. i.e.
EXPECT_TRUE(element->visibleBoundsInViewport().isEmpty())

[tkent, 2016/08/09 03:17:12]

Done.  I improved the test scenario to make its purpose clearer.

+}
+
 // Test that the various window.scroll and document.body.scroll properties and
 // methods work unchanged from the pre-virtual viewport mode.
 TEST_P(ParameterizedVisualViewportTest, bodyAndWindowScrollPropertiesAccountForViewport)
 {
     initializeWithAndroidSettings();
 
     webViewImpl()->resize(IntSize(200, 300));
 
     // Load page with no main frame scrolling.
     registerMockedHttpURLLoad("200-by-300-viewport.html");
@@ skipping 282 matching lines @@
     FrameView& frameView = *webViewImpl()->mainFrameImpl()->frameView();
     frameView.layoutViewportScrollableArea()->setScrollPosition(DoublePoint(700, 500), ProgrammaticScroll);
 
     webViewImpl()->resize(IntSize(400, 300));
     EXPECT_POINT_EQ(DoublePoint(300, 200), frameView.layoutViewportScrollableArea()->scrollPositionDouble());
 
     RuntimeEnabledFeatures::setScrollAnchoringEnabled(wasScrollAnchoringEnabled);
 }
 
 } // namespace