Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2215313003: Make sure blink scheduler doesn't wait for the PingLoader (Closed)

Created:
4 years, 4 months ago by alex clarke (OOO till 29th)
Modified:
4 years, 4 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure blink scheduler doesn't wait for the PingLoader The PingLoader calls context().willStartLoadingResource but it doesn't call context().dispatchDidFinishLoading which throws off the scheduler's accounting. This patch fixes that. BUG=546953 Committed: https://crrev.com/24a36e38fda2fa1699013ce4d6fa9213deea1f86 Cr-Commit-Position: refs/heads/master@{#410173}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
alex clarke (OOO till 29th)
4 years, 4 months ago (2016-08-05 14:36:41 UTC) #4
haraken
LGTM
4 years, 4 months ago (2016-08-05 17:31:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2215313003/1
4 years, 4 months ago (2016-08-05 19:53:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 21:47:26 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 21:50:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24a36e38fda2fa1699013ce4d6fa9213deea1f86
Cr-Commit-Position: refs/heads/master@{#410173}

Powered by Google App Engine
This is Rietveld 408576698