Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 2215253002: DevTools: do not use CSSMetadata instances for autocompletion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@css-meta-data
Patch Set: address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 _showBlackboxInfobarIfNeeded: function() 142 _showBlackboxInfobarIfNeeded: function()
143 { 143 {
144 var uiSourceCode = this.uiSourceCode(); 144 var uiSourceCode = this.uiSourceCode();
145 if (!uiSourceCode.contentType().hasScripts()) 145 if (!uiSourceCode.contentType().hasScripts())
146 return; 146 return;
147 var projectType = uiSourceCode.project().type(); 147 var projectType = uiSourceCode.project().type();
148 if (projectType === WebInspector.projectTypes.Snippets) 148 if (projectType === WebInspector.projectTypes.Snippets)
149 return; 149 return;
150 var networkURL = WebInspector.networkMapping.networkURL(uiSourceCode); 150 var networkURL = WebInspector.networkMapping.networkURL(uiSourceCode);
151 var url = projectType === WebInspector.projectTypes.Formatter ? uiSource Code.url() : networkURL; 151 var url = projectType === WebInspector.projectTypes.Formatter ? uiSource Code.url() : networkURL;
152 var isContentScript = projectType === WebInspector.projectTypes.ContentS cripts;
153 if (!WebInspector.blackboxManager.isBlackboxedUISourceCode(uiSourceCode) ) { 152 if (!WebInspector.blackboxManager.isBlackboxedUISourceCode(uiSourceCode) ) {
154 this._hideBlackboxInfobar(); 153 this._hideBlackboxInfobar();
155 return; 154 return;
156 } 155 }
157 156
158 if (this._blackboxInfobar) 157 if (this._blackboxInfobar)
159 this._blackboxInfobar.dispose(); 158 this._blackboxInfobar.dispose();
160 159
161 var infobar = new WebInspector.Infobar(WebInspector.Infobar.Type.Warning , WebInspector.UIString("This script is blackboxed in debugger")); 160 var infobar = new WebInspector.Infobar(WebInspector.Infobar.Type.Warning , WebInspector.UIString("This script is blackboxed in debugger"));
162 this._blackboxInfobar = infobar; 161 this._blackboxInfobar = infobar;
(...skipping 968 matching lines...) Expand 10 before | Expand all | Expand 10 after
1131 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .WorkingCopyChanged, this._workingCopyChanged, this); 1130 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .WorkingCopyChanged, this._workingCopyChanged, this);
1132 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .WorkingCopyCommitted, this._workingCopyCommitted, this); 1131 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .WorkingCopyCommitted, this._workingCopyCommitted, this);
1133 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .TitleChanged, this._showBlackboxInfobarIfNeeded, this); 1132 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .TitleChanged, this._showBlackboxInfobarIfNeeded, this);
1134 WebInspector.moduleSetting("skipStackFramesPattern").removeChangeListene r(this._showBlackboxInfobarIfNeeded, this); 1133 WebInspector.moduleSetting("skipStackFramesPattern").removeChangeListene r(this._showBlackboxInfobarIfNeeded, this);
1135 WebInspector.moduleSetting("skipContentScripts").removeChangeListener(th is._showBlackboxInfobarIfNeeded, this); 1134 WebInspector.moduleSetting("skipContentScripts").removeChangeListener(th is._showBlackboxInfobarIfNeeded, this);
1136 WebInspector.UISourceCodeFrame.prototype.dispose.call(this); 1135 WebInspector.UISourceCodeFrame.prototype.dispose.call(this);
1137 }, 1136 },
1138 1137
1139 __proto__: WebInspector.UISourceCodeFrame.prototype 1138 __proto__: WebInspector.UISourceCodeFrame.prototype
1140 } 1139 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698