Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js

Issue 2215253002: DevTools: do not use CSSMetadata instances for autocompletion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@css-meta-data
Patch Set: address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 340 matching lines...) Expand 10 before | Expand all | Expand 10 after
351 { 351 {
352 var prefix = editor.copyRange(prefixRange); 352 var prefix = editor.copyRange(prefixRange);
353 if (prefix.startsWith("$")) 353 if (prefix.startsWith("$"))
354 return this._simpleDelegate.wordsWithPrefix(editor, prefixRange, sub stituteRange); 354 return this._simpleDelegate.wordsWithPrefix(editor, prefixRange, sub stituteRange);
355 var propertyToken = this._backtrackPropertyToken(editor, prefixRange.sta rtLine, prefixRange.startColumn - 1); 355 var propertyToken = this._backtrackPropertyToken(editor, prefixRange.sta rtLine, prefixRange.startColumn - 1);
356 if (!propertyToken) 356 if (!propertyToken)
357 return this._simpleDelegate.wordsWithPrefix(editor, prefixRange, sub stituteRange); 357 return this._simpleDelegate.wordsWithPrefix(editor, prefixRange, sub stituteRange);
358 358
359 var line = editor.line(prefixRange.startLine); 359 var line = editor.line(prefixRange.startLine);
360 var tokenContent = line.substring(propertyToken.startColumn, propertyTok en.endColumn); 360 var tokenContent = line.substring(propertyToken.startColumn, propertyTok en.endColumn);
361 var keywords = WebInspector.CSSMetadata.keywordsForProperty(tokenContent ); 361 var propertyValues = WebInspector.CSSMetadata.propertyValues(tokenConten t);
362 return keywords.startsWith(prefix); 362 return propertyValues.filter(value => value.startsWith(prefix));
363 }, 363 },
364 } 364 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698