mash: Migrate ShelfLayoutManager ScreenUtil usage to ash common types.

mash: Migrate ShelfLayoutManager ScreenUtil usage to ash common types.

Add WmShell::IsInUnifiedMode and GetFirstDisplay helpers.
Migrate wm::GetShelfDisplayBoundsForWindow.
Update ShelfLayoutManager ScreenUtil usage to ash/common.

BUG=615155, 622480
TEST=Automated; no [unified] shelf layout changes.
R=jamescook@chromium.org

Committed: https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0
Cr-Commit-Position: refs/heads/master@{#410253}

[msw, 2016-08-05 21:26:32]

Description was changed from

==========
mash: Migrate ShelfLayoutManager ScreenUtil usage to ash common types.

BUG=615155
==========

to

==========
mash: Migrate ShelfLayoutManager ScreenUtil usage to ash common types.

Add WmShell::IsInUnifiedMode() DisplayManager pass-through.
Add wm::GetShelfDisplayBoundsForWindow (like
ScreenUtil::GetShelfDisplayBoundsInRoot).

Convert ScreenUtil::GetDisplayBoundsInParent to wm::GetDisplayBoundsInParent.
Convert ScreenUtil::ConvertRectToScreen to WmWindow::ConvertRectToScreen,

BUG=615155
==========

[msw, 2016-08-05 23:28:37]

Patchset #3 (id:40001) has been deleted

[msw, 2016-08-05 23:31:22]

Description was changed from

==========
mash: Migrate ShelfLayoutManager ScreenUtil usage to ash common types.

Add WmShell::IsInUnifiedMode() DisplayManager pass-through.
Add wm::GetShelfDisplayBoundsForWindow (like
ScreenUtil::GetShelfDisplayBoundsInRoot).

Convert ScreenUtil::GetDisplayBoundsInParent to wm::GetDisplayBoundsInParent.
Convert ScreenUtil::ConvertRectToScreen to WmWindow::ConvertRectToScreen,

BUG=615155
==========

to

==========
mash: Migrate ShelfLayoutManager ScreenUtil usage to ash common types.

Add WmShell::IsInUnifiedMode and GetFirstDisplay helpers.
Migrate wm::GetShelfDisplayBoundsForWindow.
Update ShelfLayoutManager ScreenUtil usage to ash/common.

BUG=615155,622480
TEST=Automated; no [unified] shelf layout changes.
R=jamescook@chromium.org
==========

[msw, 2016-08-05 23:31:22]

msw@chromium.org changed reviewers:
+ jamescook@chromium.org

[msw, 2016-08-05 23:33:28]

Hey James, please take a look; thanks!
FYI Oshima, feel free to review; thanks!

[msw, 2016-08-05 23:33:47]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 23:34:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 23:45:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 23:45:59]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[James Cook, 2016-08-05 23:51:25]

LGTM with nit and an optional idea

https://codereview.chromium.org/2215223004/diff/60001/ash/common/wm/wm_screen...
File ash/common/wm/wm_screen_util.cc (right):

https://codereview.chromium.org/2215223004/diff/60001/ash/common/wm/wm_screen...
ash/common/wm/wm_screen_util.cc:45: }
Just FYI, taking out the in_mus() pieces of this function may break autohide in
mojo:sysui. I added them in https://codereview.chromium.org/2007003002. That
said, I think removing the code is the right thing to do, since sysui is going
away soon.

https://codereview.chromium.org/2215223004/diff/60001/ash/common/wm/wm_screen...
File ash/common/wm/wm_screen_util.h (right):

https://codereview.chromium.org/2215223004/diff/60001/ash/common/wm/wm_screen...
ash/common/wm/wm_screen_util.h:32: ASH_EXPORT gfx::Rect
GetShelfDisplayBoundsForWindow(WmWindow* window);
nit: I think this should be renamed to something like
GetDisplayBoundsWithShelf(WmWindow* context) or
GetDisplayBoundsWithShelfForWindow(). I keep thinking it has to do with the
shelf's bounds, and it doesn't.

https://codereview.chromium.org/2215223004/diff/60001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/2215223004/diff/60001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.cc:251: WmWindow* shelf_window =
WmLookup::Get()->GetWindowForWidget(shelf_widget_);
optional thought: I wonder if we should cache the WmWindow* shelf_window_ to
avoid calls through WmLookup. I think I added some WmLookup calls too.

[msw, 2016-08-06 00:08:14]

https://codereview.chromium.org/2215223004/diff/60001/ash/common/wm/wm_screen...
File ash/common/wm/wm_screen_util.cc (right):

https://codereview.chromium.org/2215223004/diff/60001/ash/common/wm/wm_screen...
ash/common/wm/wm_screen_util.cc:45: }
On 2016/08/05 23:51:25, James Cook wrote:
> Just FYI, taking out the in_mus() pieces of this function may break autohide
in
> mojo:sysui. I added them in https://codereview.chromium.org/2007003002. That
> said, I think removing the code is the right thing to do, since sysui is going
> away soon.

Yeah, I though it would break mash shelf layout, and figured I'd leave a TODO
here (similar to the prior patch set), but it doesn't break mash shelf layout
afaict, and it's not clear what the correct pattern should be, given that my
prior patch set's use of GetRootWindowForDisplayId caused test crashes when
changing display configurations. I think we might need a fairly different
approach as mash begins to support the display manager and multiple displays,
but I'm not sure what if anything we should leave here.

https://codereview.chromium.org/2215223004/diff/60001/ash/common/wm/wm_screen...
File ash/common/wm/wm_screen_util.h (right):

https://codereview.chromium.org/2215223004/diff/60001/ash/common/wm/wm_screen...
ash/common/wm/wm_screen_util.h:32: ASH_EXPORT gfx::Rect
GetShelfDisplayBoundsForWindow(WmWindow* window);
On 2016/08/05 23:51:25, James Cook wrote:
> nit: I think this should be renamed to something like
> GetDisplayBoundsWithShelf(WmWindow* context) or
> GetDisplayBoundsWithShelfForWindow(). I keep thinking it has to do with the
> shelf's bounds, and it doesn't.

Done. I revised the comment too.

https://codereview.chromium.org/2215223004/diff/60001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/2215223004/diff/60001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.cc:251: WmWindow* shelf_window =
WmLookup::Get()->GetWindowForWidget(shelf_widget_);
On 2016/08/05 23:51:25, James Cook wrote:
> optional thought: I wonder if we should cache the WmWindow* shelf_window_ to
> avoid calls through WmLookup. I think I added some WmLookup calls too.

Yeah, that might make sense, but I'd punt on caching it for now.

[msw, 2016-08-06 00:08:19]

The CQ bit was checked by msw@chromium.org

[msw, 2016-08-06 00:08:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2215223004/#ps80001
(title: "Address comments; fix include.")

[commit-bot: I haz the power, 2016-08-06 00:08:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-06 01:12:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-06 01:12:17]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-08-06 01:42:16]

The CQ bit was checked by msw@chromium.org

[msw, 2016-08-06 01:42:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2215223004/#ps100001
(title: "Restore screen bounds conversion for app list.")

[commit-bot: I haz the power, 2016-08-06 01:42:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-06 02:26:06]

Description was changed from

==========
mash: Migrate ShelfLayoutManager ScreenUtil usage to ash common types.

Add WmShell::IsInUnifiedMode and GetFirstDisplay helpers.
Migrate wm::GetShelfDisplayBoundsForWindow.
Update ShelfLayoutManager ScreenUtil usage to ash/common.

BUG=615155,622480
TEST=Automated; no [unified] shelf layout changes.
R=jamescook@chromium.org
==========

to

==========
mash: Migrate ShelfLayoutManager ScreenUtil usage to ash common types.

Add WmShell::IsInUnifiedMode and GetFirstDisplay helpers.
Migrate wm::GetShelfDisplayBoundsForWindow.
Update ShelfLayoutManager ScreenUtil usage to ash/common.

BUG=615155,622480
TEST=Automated; no [unified] shelf layout changes.
R=jamescook@chromium.org
==========

[commit-bot: I haz the power, 2016-08-06 02:26:07]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-08-06 02:27:41]

Description was changed from

==========
mash: Migrate ShelfLayoutManager ScreenUtil usage to ash common types.

Add WmShell::IsInUnifiedMode and GetFirstDisplay helpers.
Migrate wm::GetShelfDisplayBoundsForWindow.
Update ShelfLayoutManager ScreenUtil usage to ash/common.

BUG=615155,622480
TEST=Automated; no [unified] shelf layout changes.
R=jamescook@chromium.org
==========

to

==========
mash: Migrate ShelfLayoutManager ScreenUtil usage to ash common types.

Add WmShell::IsInUnifiedMode and GetFirstDisplay helpers.
Migrate wm::GetShelfDisplayBoundsForWindow.
Update ShelfLayoutManager ScreenUtil usage to ash/common.

BUG=615155,622480
TEST=Automated; no [unified] shelf layout changes.
R=jamescook@chromium.org

Committed: https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0
Cr-Commit-Position: refs/heads/master@{#410253}
==========

[commit-bot: I haz the power, 2016-08-06 02:27:42]

Patchset 5 (id:??) landed as
https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0
Cr-Commit-Position: refs/heads/master@{#410253}