Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2215223003: Moves most frame related classes to ash/common/frame (Closed)

Created:
4 years, 4 months ago by sky
Modified:
4 years, 4 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves most frame related classes to ash/common/frame CustomFrameViewAsh requires a bit more surgery, and frame_border_hit_test_controller isn't needed for mash. BUG=634972 TEST=none R=msw@chromium.org Committed: https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13 Cr-Commit-Position: refs/heads/master@{#410196}

Patch Set 1 #

Patch Set 2 : comment #

Patch Set 3 : merge #

Patch Set 4 : moar #

Patch Set 5 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -2481 lines) Patch
M ash/ash.gyp View 1 2 4 chunks +17 lines, -15 lines 0 comments Download
A + ash/common/frame/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/frame/caption_buttons/caption_button_types.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/frame/caption_buttons/frame_caption_button.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/frame/caption_buttons/frame_caption_button.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/frame/caption_buttons/frame_caption_button_container_view.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/frame/caption_buttons/frame_caption_button_container_view.cc View 1 chunk +3 lines, -4 lines 0 comments Download
A + ash/common/frame/caption_buttons/frame_caption_button_container_view_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
A + ash/common/frame/caption_buttons/frame_size_button.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + ash/common/frame/caption_buttons/frame_size_button.cc View 3 chunks +12 lines, -19 lines 0 comments Download
A + ash/common/frame/caption_buttons/frame_size_button_delegate.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/frame/default_header_painter.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/frame/default_header_painter.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + ash/common/frame/default_header_painter_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A ash/common/frame/frame_border_hit_test.h View 1 1 chunk +30 lines, -0 lines 0 comments Download
A + ash/common/frame/frame_border_hit_test.cc View 2 chunks +6 lines, -22 lines 0 comments Download
A + ash/common/frame/header_painter.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/frame/header_painter_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/frame/header_painter_util.cc View 2 chunks +6 lines, -5 lines 0 comments Download
D ash/frame/caption_buttons/caption_button_types.h View 1 chunk +0 lines, -25 lines 0 comments Download
D ash/frame/caption_buttons/frame_caption_button.h View 1 chunk +0 lines, -108 lines 0 comments Download
D ash/frame/caption_buttons/frame_caption_button.cc View 1 chunk +0 lines, -189 lines 0 comments Download
D ash/frame/caption_buttons/frame_caption_button_container_view.h View 1 chunk +0 lines, -157 lines 0 comments Download
D ash/frame/caption_buttons/frame_caption_button_container_view.cc View 1 chunk +0 lines, -413 lines 0 comments Download
D ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc View 1 chunk +0 lines, -205 lines 0 comments Download
D ash/frame/caption_buttons/frame_size_button.h View 1 chunk +0 lines, -120 lines 0 comments Download
D ash/frame/caption_buttons/frame_size_button.cc View 1 chunk +0 lines, -278 lines 0 comments Download
D ash/frame/caption_buttons/frame_size_button_delegate.h View 1 chunk +0 lines, -55 lines 0 comments Download
M ash/frame/caption_buttons/frame_size_button_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/frame/custom_frame_view_ash.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M ash/frame/custom_frame_view_ash_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D ash/frame/default_header_painter.h View 1 chunk +0 lines, -120 lines 0 comments Download
D ash/frame/default_header_painter.cc View 1 chunk +0 lines, -319 lines 0 comments Download
D ash/frame/default_header_painter_unittest.cc View 1 chunk +0 lines, -85 lines 0 comments Download
M ash/frame/frame_border_hit_test_controller.h View 1 2 3 4 1 chunk +1 line, -14 lines 0 comments Download
M ash/frame/frame_border_hit_test_controller.cc View 2 chunks +0 lines, -60 lines 0 comments Download
D ash/frame/header_painter.h View 1 chunk +0 lines, -47 lines 0 comments Download
D ash/frame/header_painter_util.h View 1 chunk +0 lines, -55 lines 0 comments Download
D ash/frame/header_painter_util.cc View 1 chunk +0 lines, -97 lines 0 comments Download
M ash/touch/touch_uma.h View 1 chunk +10 lines, -5 lines 0 comments Download
M ash/touch/touch_uma.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/panels/panel_frame_view.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_header_painter_ash.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_header_painter_ash.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/web_app_left_header_view_ash.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/web_app_left_header_view_ash_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
sky
4 years, 4 months ago (2016-08-05 19:41:37 UTC) #1
msw
lgtm
4 years, 4 months ago (2016-08-05 22:24:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2215223003/80001
4 years, 4 months ago (2016-08-05 22:27:50 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-05 22:33:52 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 22:36:39 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13
Cr-Commit-Position: refs/heads/master@{#410196}

Powered by Google App Engine
This is Rietveld 408576698