Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2215203002: Remove double include of testharness.js in variable tests (Closed)

Created:
4 years, 4 months ago by gsnedders
Modified:
4 years ago
Reviewers:
dstockwell, shans, rjwright
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove double include of testharness.js in variable tests This prevents us from getting a second harness message, as the second instance times out, 10 seconds after the tests complete. BUG=634567

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/variables/custom-properties-serialization.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/variables/custom-properties-serialization-quirks-mode.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
gsnedders
4 years, 4 months ago (2016-08-05 01:27:08 UTC) #3
rjwright
On 2016/08/05 01:27:08, gsnedders wrote: lgtm
4 years, 4 months ago (2016-08-05 05:32:03 UTC) #4
dstockwell
lgtm
4 years, 4 months ago (2016-08-10 07:34:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2215203002/1
4 years, 4 months ago (2016-08-10 07:34:55 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/234750)
4 years, 4 months ago (2016-08-10 07:40:49 UTC) #10
dstockwell
On 2016/08/10 at 07:40:49, commit-bot wrote: > Try jobs failed on following builders: > chromium_presubmit ...
4 years, 4 months ago (2016-08-10 07:42:03 UTC) #11
gsnedders
There's been discussion by email with regards to the interaction between being a Google contractor ...
4 years, 4 months ago (2016-08-15 18:12:09 UTC) #12
Mike Lawther (Google)
4 years, 3 months ago (2016-09-08 01:45:55 UTC) #13
Any update to this situation?

Powered by Google App Engine
This is Rietveld 408576698