Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 22152003: Never hchange nan-hole to hole or hole to nan-hole. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Add individual test-file Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | src/hydrogen-mark-deoptimize.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4826 matching lines...) Expand 10 before | Expand all | Expand 10 after
4837 Label done; 4837 Label done;
4838 if (convert_hole) { 4838 if (convert_hole) {
4839 DwVfpRegister input_reg = ToDoubleRegister(instr->value()); 4839 DwVfpRegister input_reg = ToDoubleRegister(instr->value());
4840 __ VFPCompareAndSetFlags(input_reg, input_reg); 4840 __ VFPCompareAndSetFlags(input_reg, input_reg);
4841 __ b(vc, &no_special_nan_handling); 4841 __ b(vc, &no_special_nan_handling);
4842 __ VmovHigh(scratch, input_reg); 4842 __ VmovHigh(scratch, input_reg);
4843 __ cmp(scratch, Operand(kHoleNanUpper32)); 4843 __ cmp(scratch, Operand(kHoleNanUpper32));
4844 // If not the hole NaN, force the NaN to be canonical. 4844 // If not the hole NaN, force the NaN to be canonical.
4845 __ VFPCanonicalizeNaN(input_reg, ne); 4845 __ VFPCanonicalizeNaN(input_reg, ne);
4846 __ b(ne, &no_special_nan_handling); 4846 __ b(ne, &no_special_nan_handling);
4847 __ Move(reg, factory()->the_hole_value()); 4847 __ Move(reg, factory()->undefined_value());
4848 __ b(&done); 4848 __ b(&done);
4849 } 4849 }
4850 4850
4851 __ bind(&no_special_nan_handling); 4851 __ bind(&no_special_nan_handling);
4852 DeferredNumberTagD* deferred = new(zone()) DeferredNumberTagD(this, instr); 4852 DeferredNumberTagD* deferred = new(zone()) DeferredNumberTagD(this, instr);
4853 if (FLAG_inline_new) { 4853 if (FLAG_inline_new) {
4854 __ LoadRoot(scratch, Heap::kHeapNumberMapRootIndex); 4854 __ LoadRoot(scratch, Heap::kHeapNumberMapRootIndex);
4855 // We want the untagged address first for performance 4855 // We want the untagged address first for performance
4856 __ AllocateHeapNumber(reg, temp1, temp2, scratch, deferred->entry(), 4856 __ AllocateHeapNumber(reg, temp1, temp2, scratch, deferred->entry(),
4857 DONT_TAG_RESULT); 4857 DONT_TAG_RESULT);
(...skipping 998 matching lines...) Expand 10 before | Expand all | Expand 10 after
5856 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index)); 5856 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index));
5857 __ ldr(result, FieldMemOperand(scratch, 5857 __ ldr(result, FieldMemOperand(scratch,
5858 FixedArray::kHeaderSize - kPointerSize)); 5858 FixedArray::kHeaderSize - kPointerSize));
5859 __ bind(&done); 5859 __ bind(&done);
5860 } 5860 }
5861 5861
5862 5862
5863 #undef __ 5863 #undef __
5864 5864
5865 } } // namespace v8::internal 5865 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | src/hydrogen-mark-deoptimize.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698