Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2215193003: DO NOT COMMIT -- Very confusing patch... (Closed)

Created:
4 years, 4 months ago by gab
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@b1_dcheckfailedcatch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DO NOT COMMIT -- Very confusing patch... This makes ContinueOnShutdown/TaskSchedulerTaskTrackerTest.SingletonAllowed/0 pass i.e. hit DCHECK instead of crash... BUG=634552

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M base/task_scheduler/task_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/task_scheduler/task_tracker_unittest.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 2213933003 Patch 100001

Messages

Total messages: 1 (1 generated)
gab
4 years, 4 months ago (2016-08-05 00:17:52 UTC) #1 
Description was changed from

==========
DO NOT COMMIT -- Very confusing patch...

This makes ContinueOnShutdown/TaskSchedulerTaskTrackerTest.SingletonAllowed/0
pass
i.e. hit DCHECK instead of crash...

BUG=
==========

to

==========
DO NOT COMMIT -- Very confusing patch...

This makes ContinueOnShutdown/TaskSchedulerTaskTrackerTest.SingletonAllowed/0
pass
i.e. hit DCHECK instead of crash...

BUG=634552
==========

Powered by Google App Engine
This is Rietveld 408576698