Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.h

Issue 2215153002: [DevTools] Eliminate frameId and isContentScript from js protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: navigation tracker Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.h b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.h
index 60d93d819864936ecdddfde829f0559d60da1f53..d3e9d8d02d5faa8d6b8f847c8e1597fcd912c54a 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.h
@@ -42,19 +42,19 @@ public:
V8DebuggerScript(v8::Isolate*, v8::Local<v8::Object>, bool isLiveEdit);
~V8DebuggerScript();
- String16 scriptId() const { return m_id; }
- String16 url() const { return m_url; }
+ const String16& scriptId() const { return m_id; }
+ const String16& url() const { return m_url; }
bool hasSourceURL() const { return !m_sourceURL.isEmpty(); }
- String16 sourceURL() const;
- String16 sourceMappingURL() const { return m_sourceMappingURL; }
+ const String16& sourceURL() const;
+ const String16& sourceMappingURL() const { return m_sourceMappingURL; }
v8::Local<v8::String> source(v8::Isolate*) const;
- String16 hash() const { return m_hash; }
+ const String16& hash() const { return m_hash; }
int startLine() const { return m_startLine; }
int startColumn() const { return m_startColumn; }
int endLine() const { return m_endLine; }
int endColumn() const { return m_endColumn; }
int executionContextId() const { return m_executionContextId; }
- bool isContentScript() const { return m_isContentScript; }
+ const String16& executionContextAuxData() const { return m_executionContextAuxData; }
bool isInternalScript() const { return m_isInternalScript; }
bool isLiveEdit() const { return m_isLiveEdit; }
@@ -74,7 +74,7 @@ private:
int m_endLine;
int m_endColumn;
int m_executionContextId;
- bool m_isContentScript;
+ String16 m_executionContextAuxData;
bool m_isInternalScript;
bool m_isLiveEdit;
};

Powered by Google App Engine
This is Rietveld 408576698