Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2215143002: Update new test to check asserts only if they are enabled and remove VM option. (Closed)

Created:
4 years, 4 months ago by regis
Modified:
4 years, 4 months ago
Reviewers:
Florian Schneider, siva
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update new test to check asserts only if they are enabled and remove VM option. It seems like asserts are not supported correctly in product mode. Committed: https://github.com/dart-lang/sdk/commit/c8910f9d38cf81a28c663124764470bd7e349974

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M tests/standalone/fixed_precision_double_test.dart View 3 chunks +17 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
regis
I will file an issue against product mode not supporting asserts.
4 years, 4 months ago (2016-08-04 22:45:50 UTC) #2
regis
On 2016/08/04 22:45:50, regis wrote: > I will file an issue against product mode not ...
4 years, 4 months ago (2016-08-04 22:48:37 UTC) #3
regis
Committed patchset #1 (id:1) manually as c8910f9d38cf81a28c663124764470bd7e349974 (presubmit successful).
4 years, 4 months ago (2016-08-04 23:01:26 UTC) #5
regis
On 2016/08/04 22:48:37, regis wrote: > On 2016/08/04 22:45:50, regis wrote: > > I will ...
4 years, 4 months ago (2016-08-04 23:01:37 UTC) #6
Florian Schneider
4 years, 4 months ago (2016-08-04 23:06:35 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698