Avoid modifying the set returned by getInterceptorsOn()

Avoid modifying the set returned by getInterceptorsOn()

The returned set is shared.

This program generates a broken short-circuit interceptor ($n -> $din) due to modifying the cached shared set {n} to {d,i,n} 
--------
J.toInt$0$n = function(receiver) {
  return J.getInterceptor$din(receiver).toInt$0(receiver);
};
--------
import 'package:expect/expect.dart';

@NoInline()
@AssumeDynamic()
confuse(x) => x;

@NoInline()
foo(x) {
  print(x.toInt());
  bar(x);
}

@NoInline()
bar(x) {
  print(x.toInt());
  print(x.runtimeType);
}

main() {
  int i = confuse(1);
  foo(i);
  double d = confuse(2.3);
  foo(d);
}
--------

TBR=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/36f52dd43f1111cbc5b51796ab51d8136bac6b9f

[sra1, 2016-08-05 01:31:52]

Description was changed from

==========
Avoid modifying the set returned by getInterceptorsOn()

The returned set is shared.
==========

to

==========
Avoid modifying the set returned by getInterceptorsOn()

The returned set is shared.

This program generates a broken short-circuit interceptor ($n -> $din) due to
modifying the cached shared set {n} to {d,i,n} 
--------
J.toInt$0$n = function(receiver) {
  return J.getInterceptor$din(receiver).toInt$0(receiver);
};
--------
import 'package:expect/expect.dart';

@NoInline()
@AssumeDynamic()
confuse(x) => x;

@NoInline()
foo(x) {
  print(x.toInt());
  bar(x);
}

@NoInline()
bar(x) {
  print(x.toInt());
  print(x.runtimeType);
}

main() {
  int i = confuse(1);
  foo(i);
  double d = confuse(2.3);
  foo(d);
}
--------
==========

[sra1, 2016-08-05 01:31:53]

sra@google.com changed reviewers:
+ sigmund@google.com

[sra1, 2016-08-05 22:48:48]

Description was changed from

==========
Avoid modifying the set returned by getInterceptorsOn()

The returned set is shared.

This program generates a broken short-circuit interceptor ($n -> $din) due to
modifying the cached shared set {n} to {d,i,n} 
--------
J.toInt$0$n = function(receiver) {
  return J.getInterceptor$din(receiver).toInt$0(receiver);
};
--------
import 'package:expect/expect.dart';

@NoInline()
@AssumeDynamic()
confuse(x) => x;

@NoInline()
foo(x) {
  print(x.toInt());
  bar(x);
}

@NoInline()
bar(x) {
  print(x.toInt());
  print(x.runtimeType);
}

main() {
  int i = confuse(1);
  foo(i);
  double d = confuse(2.3);
  foo(d);
}
--------
==========

to

==========
Avoid modifying the set returned by getInterceptorsOn()

The returned set is shared.

This program generates a broken short-circuit interceptor ($n -> $din) due to
modifying the cached shared set {n} to {d,i,n} 
--------
J.toInt$0$n = function(receiver) {
  return J.getInterceptor$din(receiver).toInt$0(receiver);
};
--------
import 'package:expect/expect.dart';

@NoInline()
@AssumeDynamic()
confuse(x) => x;

@NoInline()
foo(x) {
  print(x.toInt());
  bar(x);
}

@NoInline()
bar(x) {
  print(x.toInt());
  print(x.runtimeType);
}

main() {
  int i = confuse(1);
  foo(i);
  double d = confuse(2.3);
  foo(d);
}
--------

TBR=sigmund@google.com
==========

[sra1, 2016-08-05 23:13:14]

Description was changed from

==========
Avoid modifying the set returned by getInterceptorsOn()

The returned set is shared.

This program generates a broken short-circuit interceptor ($n -> $din) due to
modifying the cached shared set {n} to {d,i,n} 
--------
J.toInt$0$n = function(receiver) {
  return J.getInterceptor$din(receiver).toInt$0(receiver);
};
--------
import 'package:expect/expect.dart';

@NoInline()
@AssumeDynamic()
confuse(x) => x;

@NoInline()
foo(x) {
  print(x.toInt());
  bar(x);
}

@NoInline()
bar(x) {
  print(x.toInt());
  print(x.runtimeType);
}

main() {
  int i = confuse(1);
  foo(i);
  double d = confuse(2.3);
  foo(d);
}
--------

TBR=sigmund@google.com
==========

to

==========
Avoid modifying the set returned by getInterceptorsOn()

The returned set is shared.

This program generates a broken short-circuit interceptor ($n -> $din) due to
modifying the cached shared set {n} to {d,i,n} 
--------
J.toInt$0$n = function(receiver) {
  return J.getInterceptor$din(receiver).toInt$0(receiver);
};
--------
import 'package:expect/expect.dart';

@NoInline()
@AssumeDynamic()
confuse(x) => x;

@NoInline()
foo(x) {
  print(x.toInt());
  bar(x);
}

@NoInline()
bar(x) {
  print(x.toInt());
  print(x.runtimeType);
}

main() {
  int i = confuse(1);
  foo(i);
  double d = confuse(2.3);
  foo(d);
}
--------

TBR=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/36f52dd43f1111cbc5b51796ab51d8136bac6b9f
==========

[sra1, 2016-08-05 23:13:15]

Committed patchset #1 (id:1) manually as
36f52dd43f1111cbc5b51796ab51d8136bac6b9f (presubmit successful).

[Siggi Cherem (dart-lang), 2016-08-08 15:50:49]

lgtm - would you like to add a test with the code in the description?