Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: services/shell/public/cpp/tests/interface_registry_unittest.cc

Issue 2215133002: Change signature of OnConnect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/shell/public/cpp/service_context.h ('k') | services/shell/service_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/shell/public/cpp/tests/interface_registry_unittest.cc
diff --git a/services/shell/public/cpp/tests/interface_registry_unittest.cc b/services/shell/public/cpp/tests/interface_registry_unittest.cc
index ed3205dfc75fd625484f3b211d1a9b7ed4b642de..747d9da234966e926620bbb982c0557b9e130381 100644
--- a/services/shell/public/cpp/tests/interface_registry_unittest.cc
+++ b/services/shell/public/cpp/tests/interface_registry_unittest.cc
@@ -30,7 +30,7 @@ TEST(InterfaceRegistryTest, Ownership) {
// Destruction.
{
- InterfaceRegistry registry(nullptr);
+ InterfaceRegistry registry;
InterfaceRegistry::TestApi test_api(&registry);
test_api.SetInterfaceBinderForName(new TestBinder(&delete_count), "TC1");
}
@@ -38,7 +38,7 @@ TEST(InterfaceRegistryTest, Ownership) {
// Removal.
{
- std::unique_ptr<InterfaceRegistry> registry(new InterfaceRegistry(nullptr));
+ std::unique_ptr<InterfaceRegistry> registry(new InterfaceRegistry);
InterfaceBinder* b = new TestBinder(&delete_count);
InterfaceRegistry::TestApi test_api(registry.get());
test_api.SetInterfaceBinderForName(b, "TC1");
@@ -49,7 +49,7 @@ TEST(InterfaceRegistryTest, Ownership) {
// Multiple.
{
- InterfaceRegistry registry(nullptr);
+ InterfaceRegistry registry;
InterfaceRegistry::TestApi test_api(&registry);
test_api.SetInterfaceBinderForName(new TestBinder(&delete_count), "TC1");
test_api.SetInterfaceBinderForName(new TestBinder(&delete_count), "TC2");
@@ -58,7 +58,7 @@ TEST(InterfaceRegistryTest, Ownership) {
// Re-addition.
{
- InterfaceRegistry registry(nullptr);
+ InterfaceRegistry registry;
InterfaceRegistry::TestApi test_api(&registry);
test_api.SetInterfaceBinderForName(new TestBinder(&delete_count), "TC1");
test_api.SetInterfaceBinderForName(new TestBinder(&delete_count), "TC1");
« no previous file with comments | « services/shell/public/cpp/service_context.h ('k') | services/shell/service_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698