Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: services/shell/public/cpp/service.h

Issue 2215133002: Change signature of OnConnect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/shell/public/cpp/lib/service_context.cc ('k') | services/shell/public/cpp/service_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/shell/public/cpp/service.h
diff --git a/services/shell/public/cpp/service.h b/services/shell/public/cpp/service.h
index 2ad2a57087507e96df5e54ef29df95259c770660..f7f2beeaa87d62d99ee3d5395eb00bacf2375a0f 100644
--- a/services/shell/public/cpp/service.h
+++ b/services/shell/public/cpp/service.h
@@ -9,12 +9,13 @@
#include <string>
#include "base/macros.h"
-#include "services/shell/public/cpp/connection.h"
-#include "services/shell/public/cpp/identity.h"
+#include "services/shell/public/cpp/interface_registry.h"
namespace shell {
class Connector;
+class Identity;
+class InterfaceRegistry;
class ServiceContext;
// The primary contract between a Service and the Service Manager, receiving
@@ -35,7 +36,8 @@ class Service {
// if the connection should succeed. Return false if the connection should
// be rejected and the underlying pipe closed. The default implementation
// returns false.
- virtual bool OnConnect(Connection* connection);
+ virtual bool OnConnect(const Identity& remote_identity,
+ InterfaceRegistry* registry);
// Called when the Service Manager has stopped tracking this instance. The
// service should use this as a signal to exit, and in fact its process may
@@ -48,10 +50,6 @@ class Service {
// quitting.
virtual bool OnStop();
- // TODO(rockot): remove
- virtual InterfaceProvider* GetInterfaceProviderForConnection();
- virtual InterfaceRegistry* GetInterfaceRegistryForConnection();
-
Connector* connector();
ServiceContext* context();
void set_context(std::unique_ptr<ServiceContext> context);
« no previous file with comments | « services/shell/public/cpp/lib/service_context.cc ('k') | services/shell/public/cpp/service_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698